From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>,
Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: IB/cma: Make timeout dependent on the subnet timeout
Date: Wed, 23 Apr 2014 08:30:21 -0400 [thread overview]
Message-ID: <5357B25D.2000108@dev.mellanox.co.il> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373992F2F15-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On 4/22/2014 2:41 PM, Hefty, Sean wrote:
>> +static u8 cma_get_ib_subnet_timeout(struct rdma_cm_id *id)
>> +{
>> + struct ib_port_attr attr;
>> + int ret;
>> +
>> + ret = ib_query_port(id->device, id->port_num, &attr);
>> + return ret == 0 ? attr.subnet_timeout : 18;
>> +}
>
> Can we query the port once (or only on a change) and cache the result, rather than querying it for every request?
To be IBA spec compliant, SubnetTimeout could change so some new local
event would need to be added and handled to avoid the requerying.
In practice, however, that's not very likely AFAIK.
-- Hal
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-23 12:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 13:16 IB/cma: Make timeout dependent on the subnet timeout Bart Van Assche
[not found] ` <53566BB5.5030203-HInyCGIudOg@public.gmane.org>
2014-04-22 18:41 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373992F2F15-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-23 12:30 ` Hal Rosenstock [this message]
[not found] ` <5357B25D.2000108-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-04-23 12:46 ` Bart Van Assche
[not found] ` <5357B626.8050209-HInyCGIudOg@public.gmane.org>
2014-04-23 12:55 ` Hal Rosenstock
[not found] ` <5357B83A.5070000-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-04-23 14:34 ` Weiny, Ira
2014-04-23 13:44 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373992F32A2-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-24 7:39 ` Or Gerlitz
[not found] ` <5358BF9D.4030409-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-04-25 2:59 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373992F4F6E-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-25 16:21 ` Bart Van Assche
[not found] ` <535A8BA6.4090603-HInyCGIudOg@public.gmane.org>
2014-04-25 16:56 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373992F50A6-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-25 17:47 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5357B25D.2000108@dev.mellanox.co.il \
--to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=bvanassche-HInyCGIudOg@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox