Re: [PATCH] svcrdma: refactor marshalling logic

[Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>]

On 4/25/2014 8:24 AM, Chuck Lever wrote:
> Hi Bruce-
>
> On Apr 25, 2014, at 6:58 AM, J. Bruce Fields <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org> wrote:
>
>> On Thu, Apr 10, 2014 at 01:37:23PM -0500, Steve Wise wrote:
>>> From: Tom Tucker <tom-/Yg/VP3ZvrM@public.gmane.org>
>>>
>>> This patch refactors the marshalling logic to remove the intermediary
>>> map structures.  It also fixes an existing bug where the NFSRDMA server
>>> was not minding the device fast register page list length limitations.
>>>
>>> Signed-off-by: Tom Tucker <tom-/Yg/VP3ZvrM@public.gmane.org>
>>> ---
>>>
>>> include/linux/sunrpc/svc_rdma.h          |    3
>>> net/sunrpc/xprtrdma/svc_rdma_recvfrom.c  |  551 +++++++++---------------------
>>> net/sunrpc/xprtrdma/svc_rdma_sendto.c    |  230 +------------
>>> net/sunrpc/xprtrdma/svc_rdma_transport.c |   57 ++-
>>> 4 files changed, 222 insertions(+), 619 deletions(-)
>> Is it possible to make this change in more than one step?
>>
>> RDMA is pretty esoteric to most of us, so honestly this will probably
>> get merged based just on your having tested it, but if it was possible
>> to break this up into smaller patches you might give us at least a
>> fighting chance of giving it some review….
> I agree it could be broken up.
>
> However, my testing revealed that the patch inadvertently breaks support
> for HCAs that do not support FRMR.  I’ve reported this to Steve and Tom.
> IMO you should wait for a newer version of the refactoring patch.

I'll figure out the regression, and work with tom to repost this as a 
series.

Steve.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html