From: Amir Vadai <amirv@mellanox.com>
To: Joe Perches <joe@perches.com>, netdev@vger.kernel.org
Cc: Eli Cohen <eli@mellanox.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] mellanox: Logging message cleanups
Date: Mon, 5 May 2014 10:30:27 +0300 [thread overview]
Message-ID: <53673E13.6070708@mellanox.com> (raw)
In-Reply-To: <e029b6ed75d46cfbada06622df91d4d331eeabde.1399259459.git.joe@perches.com>
On 5/5/2014 6:35 AM, Joe Perches wrote:
> Use a more current logging style.
>
> o Coalesce formats
> o Add missing spaces for coalesced formats
> o Align arguments for modified formats
> o Add missing newlines for some logging messages
> o Use DRV_NAME as part of format instead of %s, DRV_NAME to
> reduce overall text.
> o Use ..., ##__VA_ARGS__ instead of args... in macros
> o Correct a few format typos
> o Use a single line message where appropriate
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/net/ethernet/mellanox/mlx4/cmd.c | 85 ++++---
> drivers/net/ethernet/mellanox/mlx4/en_cq.c | 3 +-
> drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 6 +-
> drivers/net/ethernet/mellanox/mlx4/en_main.c | 7 +-
> drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 8 +-
> drivers/net/ethernet/mellanox/mlx4/en_rx.c | 17 +-
> drivers/net/ethernet/mellanox/mlx4/en_tx.c | 8 +-
> drivers/net/ethernet/mellanox/mlx4/eq.c | 85 +++----
> drivers/net/ethernet/mellanox/mlx4/fw.c | 25 +--
> drivers/net/ethernet/mellanox/mlx4/main.c | 246 +++++++++------------
> drivers/net/ethernet/mellanox/mlx4/mcg.c | 16 +-
> drivers/net/ethernet/mellanox/mlx4/mlx4.h | 17 +-
> drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 40 ++--
> drivers/net/ethernet/mellanox/mlx4/mr.c | 14 +-
> drivers/net/ethernet/mellanox/mlx4/port.c | 12 +-
> drivers/net/ethernet/mellanox/mlx4/profile.c | 13 +-
> drivers/net/ethernet/mellanox/mlx4/qp.c | 7 +-
> drivers/net/ethernet/mellanox/mlx4/reset.c | 24 +-
> .../net/ethernet/mellanox/mlx4/resource_tracker.c | 73 +++---
> drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 4 +-
> drivers/net/ethernet/mellanox/mlx5/core/eq.c | 9 +-
> drivers/net/ethernet/mellanox/mlx5/core/main.c | 14 +-
> .../net/ethernet/mellanox/mlx5/core/mlx5_core.h | 30 +--
> drivers/net/ethernet/mellanox/mlx5/core/mr.c | 8 +-
> .../net/ethernet/mellanox/mlx5/core/pagealloc.c | 15 +-
> drivers/net/ethernet/mellanox/mlx5/core/qp.c | 4 +-
> 26 files changed, 353 insertions(+), 437 deletions(-)
>
[...]
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
> index d16a4d1..0a87169 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/fw.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
> @@ -1,3 +1,4 @@
> +
new line
> /*
> * Copyright (c) 2004, 2005 Topspin Communications. All rights reserved.
> * Copyright (c) 2005, 2006, 2007, 2008 Mellanox Technologies. All rights reserved.
> @@ -428,8 +429,7 @@ int mlx4_QUERY_FUNC_CAP(struct mlx4_dev *dev, u32 gen_or_port,
> } else if (dev->caps.port_type[gen_or_port] == MLX4_PORT_TYPE_IB) {
> MLX4_GET(field, outbox, QUERY_FUNC_CAP_FLAGS0_OFFSET);
> if (field & QUERY_FUNC_CAP_FLAGS0_FORCE_PHY_WQE_GID) {
> - mlx4_err(dev, "phy_wqe_gid is "
> - "enforced on this ib port\n");
> + mlx4_err(dev, "phy_wqe_gid is enforced on this ib port\n");
> err = -EPROTONOSUPPORT;
> goto out;
> }
[...]
Acked-By: Amir Vadai <amirv@mellanox.com>
Thanks,
Amir
next prev parent reply other threads:[~2014-05-05 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 3:35 [PATCH] mellanox: Logging message cleanups Joe Perches
2014-05-05 7:30 ` Amir Vadai [this message]
[not found] ` <e029b6ed75d46cfbada06622df91d4d331eeabde.1399259459.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2014-05-07 19:41 ` David Miller
2014-05-07 19:52 ` [PATCH V2] " Joe Perches
[not found] ` <eceba320507a1895ff8f1a5bd0b7a67839e7b7b0.1399492267.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2014-05-09 3:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53673E13.6070708@mellanox.com \
--to=amirv@mellanox.com \
--cc=eli@mellanox.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox