Re: [PATCH libibverbs V3 3/3] Add ibv_query_port_ex support

Jason Gunthorpe
2014-05-12T06:35:23Z

On Sun, May 11, 2014 at 03:35:56PM +0300, Or Gerlitz wrote:

> Jason, I am clueless on what you are talking (please read below), I
> think you are mixing things (see the DD comment below too)

Way back at the start, in 2011, when Liran posted this - the first
patch set of this concept did not reorganize the driver startup
process so it needed to have two function pointers to allow libverbs a
chance to hook things.

Instead we re-organized the startup process so that verbs allocates
the context entirely and calls into the driver to set it up. This
allows verbs to do whatever it wants to the function pointers,
including copying the driver version to verbs-private-memory and
overriding with it's own - should that be necessary.

For this reason the drv_/ib_ scheme was entirely removed.

The patches that Tzahi/Sean/etc posted to implement XRC did not use
it, it hasn't been part of the concept for 3 years. Not sure where
you+Matan got the idea from.

> >Or, it would be helpful to me if you could go back to libibverbs
> >commit cbf2a35162a [...] and post the corrected flow steering
> >patches with the ABI/API change as a distinct patch. I think I
> >caught everything, but lets also correct that process error and
> >hopefully Sean/etc can comment too.

> I'm not sure we need to roll back to commit cbf2a35162a and start
> from there, but if people feel this is the right thing to do, let it
> be.

I would like to see at the very least a clean patch, introducing only
the API for flow steering, that follows the procedure I suggested.

This is to show we are all on the same page. I'm not suggesting
rolling back Roland's tree, just that you go back to that point and
re-issue the patches as a learning exercise for us all.

Follow up with a correction patch to Roland's tip.

Jason