From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH 1/2] libiscsi, iser: Adjust data_length to include protection information Date: Thu, 05 Jun 2014 20:29:12 +0300 Message-ID: <5390A8E8.6080300@dev.mellanox.co.il> References: <1401639581-20111-1-git-send-email-sagig@mellanox.com> <1401639581-20111-2-git-send-email-sagig@mellanox.com> <538DF27F.50903@cs.wisc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Martin K. Petersen" , Mike Christie Cc: Sagi Grimberg , nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, oren-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 6/4/2014 1:18 AM, Martin K. Petersen wrote: >>>>>> "Mike" == Mike Christie writes: > Mike> On 06/01/2014 11:19 AM, Sagi Grimberg wrote: >>> +/* >>> + * data integrity helpers >>> + */ >>> +static inline unsigned +iscsi_prot_len(unsigned data_len, unsigned >>> sector_size) +{ >>> + switch (sector_size) { >>> + case 512: >>> + return (data_len >> 9) * 8; >>> + case 1024: >>> + return (data_len >> 10) * 8; >>> + case 2048: >>> + return (data_len >> 11) * 8; >>> + case 4096: >>> + return (data_len >> 12) * 8; >>> + default: >>> + return (data_len >> ilog2(sector_size)) * 8; >>> + } >>> +} >>> #endif > Mike> I do not think this should not be in the iscsi code. > > In the data integrity update I posted there's a flag saying "transfer PI > on the wire". That was meant to be the thing driver's should key off of > to adjust transfer length. But I'm also happy to provide a unsigned int > scsi_transfer_length(struct scsi_cmnd *) thingy that returns the right > byte count. Just bear in mind that the host-facing DIX transfer length > may be different. > OK, let me prepare v1 moving this logic to a scsi helper and we'll have another round of comments. Thanks, Sagi. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html