From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: [PATCH] infinibad: fix memory leak in function send_flowc Date: Mon, 16 Jun 2014 13:34:27 -0500 Message-ID: <539F38B3.2020405@opengridcomputing.com> References: <1402943456-7532-1-git-send-email-xerofoify@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1402943456-7532-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nicholas Krause , swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org Cc: roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 6/16/2014 1:30 PM, Nicholas Krause wrote: > Signed-off-by: Nicholas Krause > --- > drivers/infiniband/hw/cxgb4/cm.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c > index 5e153f6..c518411 100644 > --- a/drivers/infiniband/hw/cxgb4/cm.c > +++ b/drivers/infiniband/hw/cxgb4/cm.c > @@ -455,7 +455,10 @@ static void send_flowc(struct c4iw_ep *ep, struct sk_buff *skb) > unsigned int flowclen = 80; > struct fw_flowc_wr *flowc; > int i; > > + if (!skb) { > + kfree_skb(); > + pr_warn(MOD "%s failed to allocate skb.\n", __func__); > + } > skb = get_skb(skb, flowclen, GFP_KERNEL); Oops, shouldn't the if statement be after the call to get_skb()? :) (you're having a bad day ;)) > flowc = (struct fw_flowc_wr *)__skb_put(skb, flowclen); > One more nit: The comment is no longer correct. It should be something like: iw_cxgb4: in send_flowc(), handle a null skb return from get_skb() -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html