From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: "Hefty, Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-rdma
(linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH librdmacm] [TRIVIAL] rsocket.c: In rsetsockopt, for RDMA_ROUTE option, use malloc rather than calloc
Date: Wed, 18 Jun 2014 10:30:38 -0400 [thread overview]
Message-ID: <53A1A28E.7000408@dev.mellanox.co.il> (raw)
No need to clear allocated memory as immediately followed by
memcpy which covers the allocated memory.
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/src/rsocket.c b/src/rsocket.c
index 3a9ff7d..a3c5385 100644
--- a/src/rsocket.c
+++ b/src/rsocket.c
@@ -3473,7 +3473,7 @@ int rsetsockopt(int socket, int level, int optname,
ret = 0;
break;
case RDMA_ROUTE:
- if ((rs->optval = calloc(optlen, 1))) {
+ if ((rs->optval = malloc(optlen))) {
memcpy(rs->optval, optval, optlen);
rs->optlen = optlen;
ret = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2014-06-18 14:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 14:30 Hal Rosenstock [this message]
[not found] ` <53A1A28E.7000408-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-06-18 17:07 ` [PATCH librdmacm] [TRIVIAL] rsocket.c: In rsetsockopt, for RDMA_ROUTE option, use malloc rather than calloc Hefty, Sean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A1A28E.7000408@dev.mellanox.co.il \
--to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox