public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Yishai Hadas <yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: vijaymohan.pandarathil-VXdhtT5mjnY@public.gmane.org
Cc: bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	myron.stowe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	"linux-rdma
	(linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
	<yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: PCI/AER: AER in SRIOV environment
Date: Mon, 23 Jun 2014 17:29:26 +0300	[thread overview]
Message-ID: <53A839C6.5050102@dev.mellanox.co.il> (raw)

Hi Vijay,
Trying to add AER support for Mellanox NIC in SRIOV environment, while 
evaluating/testing encountered a problem which led me to your
patch accepted as part of kernel 3.8, commit ID 
"918b4053184c0ca22236e70e299c5343eea35304".

Have some concerns/questions on:
When working in SRIOV environment VFs may be un-attached, having no 
driver assigned to, or may be attached to Virtual machine to work in 
some pass-through mode.
Once working in KVM setup there is pci-stub driver which is loaded in 
the HYP/PF for a given attached VF.

I'm using the aer-inject kernel module and its corresponding aer-inject 
tool to simulate an error in the HYP.
In both cases your commit will cause the AER recovery to fail as there 
is no driver assigned to PF's VFs that supports AER, comparing the code 
before your change.

How such cases should work ?  my expectation was that the PF will get 
the error detected message then will recognize whether
issue is its own or one of its VFs and work accordingly, in current code 
looks like recovery failed as part of "voting" once there is no AER 
handler assigned to the VFs.

Yishai
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2014-06-23 14:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23 14:29 Yishai Hadas [this message]
     [not found] ` <53A839C6.5050102-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-06-23 19:09   ` PCI/AER: AER in SRIOV environment Bjorn Helgaas
2014-06-23 20:12     ` Don Dutile
     [not found]       ` <53A88A32.4010406-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-06-23 22:44         ` Yishai Hadas
2014-06-23 23:17           ` Alex Williamson
     [not found]           ` <53A8ADD5.7030207-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-06-24 14:56             ` Don Dutile
     [not found]               ` <53A9918D.9020607-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-06-24 16:22                 ` Yishai Hadas
2014-06-24 17:38                   ` Alex Williamson
2014-06-23 23:10       ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A839C6.5050102@dev.mellanox.co.il \
    --to=yishaih-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
    --cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=myron.stowe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=vijaymohan.pandarathil-VXdhtT5mjnY@public.gmane.org \
    --cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox