From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hal Rosenstock Subject: Re: [PATCH] rsocket: Fix crash resulting from keepalive timeout Date: Wed, 02 Jul 2014 23:04:22 -0400 Message-ID: <53B4C836.2030507@dev.mellanox.co.il> References: <1404341182-12533-1-git-send-email-sean.hefty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1404341182-12533-1-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 7/2/2014 6:46 PM, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > rclose will call shutdown only if we're connected. However, if the > keepalive failed, the socket will be in an error state. So, > no call to rshutdown, which will leave the freed rsocket on > the keepalive thread's list. > > The fix is to to have rclose remove an rsocket from being processed > by a service thread if it is still active. > > Signed-off-by: Sean Hefty Tested-by: Hal Rosenstock Thanks! -- Hal -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html