public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH opensm] osm_subnet.c: Change default for perfmgr_query_cpi option
@ 2014-07-11 14:03 Hal Rosenstock
       [not found] ` <53BFEEA9.8020107-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Hal Rosenstock @ 2014-07-11 14:03 UTC (permalink / raw)
  To: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
  Cc: Ira Weiny, Susan Coulter (skc-YOWKrPYUwWM@public.gmane.org)


New default for PerfMgr query CPI is TRUE rather than FALSE.
More admins need to use this and this was too often being missed 
during configuration so make admins turn this off rather than on
(once enabling perfmgr itself).

Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c
index 1065408..26fe78c 100644
--- a/opensm/osm_subnet.c
+++ b/opensm/osm_subnet.c
@@ -1564,7 +1564,7 @@ void osm_subn_set_default_opt(IN osm_subn_opt_t * p_opt)
 	p_opt->event_db_dump_file = NULL; /* use default */
 	p_opt->perfmgr_rm_nodes = TRUE;
 	p_opt->perfmgr_log_errors = TRUE;
-	p_opt->perfmgr_query_cpi = FALSE;
+	p_opt->perfmgr_query_cpi = TRUE;
 	p_opt->perfmgr_xmit_wait_log = FALSE;
 	p_opt->perfmgr_xmit_wait_threshold = OSM_PERFMGR_DEFAULT_XMIT_WAIT_THRESHOLD;
 #endif				/* ENABLE_OSM_PERF_MGR */
@@ -2645,7 +2645,7 @@ int osm_subn_output_conf(FILE *out, IN osm_subn_opt_t * p_opts)
 		"perfmgr_log_errors %s\n\n"
 		"# Query PerfMgt Get(ClassPortInfo) for extended capabilities\n"
 		"# Extended capabilities include 64 bit extended counters\n"
-		"# and transmit wait support (default FALSE)\n"
+		"# and transmit wait support (default TRUE)\n"
 		"perfmgr_query_cpi %s\n\n"
 		"# Log xmit_wait errors (default FALSE)\n"
 		"perfmgr_xmit_wait_log %s\n\n"
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH opensm] osm_subnet.c: Change default for perfmgr_query_cpi option
       [not found] ` <53BFEEA9.8020107-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2014-07-12 14:54   ` Weiny, Ira
  0 siblings, 0 replies; 2+ messages in thread
From: Weiny, Ira @ 2014-07-12 14:54 UTC (permalink / raw)
  To: Hal Rosenstock,
	linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
  Cc: Susan Coulter (skc-YOWKrPYUwWM@public.gmane.org)

> 
> 
> New default for PerfMgr query CPI is TRUE rather than FALSE.
> More admins need to use this and this was too often being missed during
> configuration so make admins turn this off rather than on (once enabling
> perfmgr itself).
> 
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Signed-off-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

> ---
> diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c index
> 1065408..26fe78c 100644
> --- a/opensm/osm_subnet.c
> +++ b/opensm/osm_subnet.c
> @@ -1564,7 +1564,7 @@ void osm_subn_set_default_opt(IN
> osm_subn_opt_t * p_opt)
>  	p_opt->event_db_dump_file = NULL; /* use default */
>  	p_opt->perfmgr_rm_nodes = TRUE;
>  	p_opt->perfmgr_log_errors = TRUE;
> -	p_opt->perfmgr_query_cpi = FALSE;
> +	p_opt->perfmgr_query_cpi = TRUE;
>  	p_opt->perfmgr_xmit_wait_log = FALSE;
>  	p_opt->perfmgr_xmit_wait_threshold =
> OSM_PERFMGR_DEFAULT_XMIT_WAIT_THRESHOLD;
>  #endif				/* ENABLE_OSM_PERF_MGR */
> @@ -2645,7 +2645,7 @@ int osm_subn_output_conf(FILE *out, IN
> osm_subn_opt_t * p_opts)
>  		"perfmgr_log_errors %s\n\n"
>  		"# Query PerfMgt Get(ClassPortInfo) for extended
> capabilities\n"
>  		"# Extended capabilities include 64 bit extended counters\n"
> -		"# and transmit wait support (default FALSE)\n"
> +		"# and transmit wait support (default TRUE)\n"
>  		"perfmgr_query_cpi %s\n\n"
>  		"# Log xmit_wait errors (default FALSE)\n"
>  		"perfmgr_xmit_wait_log %s\n\n"
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-12 14:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-11 14:03 [PATCH opensm] osm_subnet.c: Change default for perfmgr_query_cpi option Hal Rosenstock
     [not found] ` <53BFEEA9.8020107-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-07-12 14:54   ` Weiny, Ira

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox