Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

Martin K. Petersen
2014-06-25T11:29:01Z

>>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:

Christoph> So here we use blk_rq_bytes still, which is incorrect for
Christoph> WRITE SAME.

Yeah, scsi_transfer_length() needs to go away completely if we go with
the in and out variants.

Christoph> I think the easiest fix is to just pass a scsi_data_buffer to
Christoph> scsi_transfer_length(), and let the caller use
Christoph> scsi_in/scsi_out to find the right one.

I'm perfectly OK with that approach.

--
Martin K. Petersen Oracle Linux Engineering