Re: [PATCH v2 2/3] libiscsi, iser: Adjust data_length to include protection information

Boaz Harrosh
2014-08-14T07:17:53Z

On 08/13/2014 04:09 PM, Sagi Grimberg wrote:
> On 8/6/2014 4:25 PM, Boaz Harrosh wrote:
>
> Hey Boaz,
>
> So in the current flow, I still don't think it is wrong/buggy, the
> transfer byte length related to scsi buffer length
(In iscsi for sure
> but I think that for all transports it is the same).
>
> But,
> Since you have such a strong objection on this I'm also OK with changing
> stuff... We can pass a buffer to scsi_transfer_length (although it has
> no meaning effectively) and we can keep in/out_len local variables and
> print them along with total transfer.
>
> Do you want me to send out a patch here (since I have some hardware to
> test it...) or are you still planning to send out something?
>

I'll do it. As you said there is no bugs, just ugly code. I will send a
cleanup

Thanks
Boaz

> Cheers,
> Sagi.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html