From: Allison Henderson <allison.henderson@oracle.com>
To: "shuah@kernel.org" <shuah@kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"alessandro.zanni87@gmail.com" <alessandro.zanni87@gmail.com>,
"pabeni@redhat.com" <pabeni@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"anupnewsmail@gmail.com" <anupnewsmail@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v2] selftests: net/rds: add module not found
Date: Fri, 11 Oct 2024 05:58:44 +0000 [thread overview]
Message-ID: <53ab195125ebacfd182d004a5913e0da070c5984.camel@oracle.com> (raw)
In-Reply-To: <20241010194421.48198-1-alessandro.zanni87@gmail.com>
On Thu, 2024-10-10 at 21:44 +0200, Alessandro Zanni wrote:
> This fix solves this error, when calling kselftest with targets
> "net/rds":
>
> The error was found by running tests manually with the command:
> make kselftest TARGETS="net/rds"
>
> The patch also specifies to import ip() function from the utils
> module.
>
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
I think this one looks ok. Thanks Alessandro!
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
>
> Notes:
> v2:
> modified the way the parent path is added
> added test to reproduce the error
>
> tools/testing/selftests/net/rds/test.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/rds/test.py
> b/tools/testing/selftests/net/rds/test.py
> index e6bb109bcead..4a7178d11193 100755
> --- a/tools/testing/selftests/net/rds/test.py
> +++ b/tools/testing/selftests/net/rds/test.py
> @@ -14,8 +14,11 @@ import sys
> import atexit
> from pwd import getpwuid
> from os import stat
> -from lib.py import ip
>
> +# Allow utils module to be imported from different directory
> +this_dir = os.path.dirname(os.path.realpath(__file__))
> +sys.path.append(os.path.join(this_dir, "../"))
> +from lib.py.utils import ip
>
> libc = ctypes.cdll.LoadLibrary('libc.so.6')
> setns = libc.setns
next prev parent reply other threads:[~2024-10-11 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 19:44 [PATCH v2] selftests: net/rds: add module not found Alessandro Zanni
2024-10-11 5:58 ` Allison Henderson [this message]
2024-10-11 23:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ab195125ebacfd182d004a5913e0da070c5984.camel@oracle.com \
--to=allison.henderson@oracle.com \
--cc=alessandro.zanni87@gmail.com \
--cc=anupnewsmail@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox