From mboxrd@z Thu Jan 1 00:00:00 1970 From: oulijun Subject: Re: [rdma-next 13/22] RDMA/hns: Remove empty functions Date: Tue, 15 Aug 2017 11:36:49 +0800 Message-ID: <53ea1ede-848a-25b1-5fac-bd1594a2e143@huawei.com> References: <20170811105003.7661-1-leon@kernel.org> <20170811105003.7661-14-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dennis Dalessandro , Leon Romanovsky , Doug Ledford Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Leon Romanovsky List-Id: linux-rdma@vger.kernel.org 在 2017/8/11 20:26, Dennis Dalessandro 写道: > On 8/11/2017 6:49 AM, Leon Romanovsky wrote: >> From: Leon Romanovsky >> >> The functions which are not implemented can be simply ignored >> instead of defining empty function. This patch removes such functions >> from hns driver. >> >> Signed-off-by: Leon Romanovsky > > I thought I replied about this or a very similar patch, but can't find the link. Regardless, I think these sort of work-in-progress stubs are OK as incremental development, part of "showing your work" but I would have expected to see them implemented in the same series, or at least soon there-after. So the fact that these are still empty after this much time. I agree, get rid of them. > > Reviewed-by: Dennis Dalessandro > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > . > Hi, Dennis Dalessandro I have tested it on D05 board and the result is fail. The detail anlaysis refer to my reply email for [rdma-next v1 13/22] patch. Thanks Lijun Ou -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html