Re: [PATCH] infiniband: use the ISCSI_LOGIN_CURRENT_STAGE macro

Sagi Grimberg
2022-11-20T11:52:29Z

title prefix should be:
iser-target: use the...

> Use the proper macro to get the current_stage value.
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> ---
> drivers/infiniband/ulp/isert/ib_isert.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> index b360a1527cd1..75404885cf98 100644
> --- a/drivers/infiniband/ulp/isert/ib_isert.c
> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
> @@ -993,9 +993,8 @@ isert_rx_login_req(struct isert_conn *isert_conn)
> * login request PDU.
> */
> login->leading_connection = (!login_req->tsih) ? 1 : 0;
> - login->current_stage =
> - (login_req->flags & ISCSI_FLAG_LOGIN_CURRENT_STAGE_MASK)
> - >> 2;
> + login->current_stage = ISCSI_LOGIN_CURRENT_STAGE(
> + login_req->flags);
> login->version_min = login_req->min_version;
> login->version_max = login_req->max_version;
> memcpy(login->isid, login_req->isid, 6);

Acked-by: Sagi Grimberg <sagi@grimberg.me>