RE: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

Minh Duc Tran
2014-10-22T04:29:30Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1297 bytes --]

>On 10/22/2014 12:11 AM, Minh Duc Tran wrote:
>> Hi Or,
>>
>>> So just to recaphere.
>>> With your driver maximal attributes of 8K CQEs per CQ and 32 CQs per device, do/what we need to change s.t that the iser initiator functional with it's current code is functional on 3.18-rc1?
>> Yes, I've just verified the patch with 3.18-rc1 on both ocrdma and mlx4 drivers. They are working as expected.
>>
>>> Are you hitting an (inability) to create a CQ?
>> Yes

>So for 3.18 we should be OK with one liner patch that makes sure the size of the created CQ is maxed out against the quantity advertized in the device attributes, agree?

Not just that one liner change. The change is about 10 lines and very simple. It should take you about 30 seconds to read it. We need the whole patch to fix two problems:
1) the create CQ failure due to requested CQ entries too large.
2) the create qp failure due to requested wr entries too large. Our hw has a limit of around 2k wr per qp in this profile. Iser calls to create qp with a hardcoded value of around 4k.

If you have other ideas how to solve our problem, please let us know.

Thanks.
-Minh

N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±­ÙšŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hš‹»öì\x17/oSc¾™Ú³9˜uÀ¦æå‰È&jw¨®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿïêäz¹Þ–Šàþf£¢·hšˆ§~ˆmš