From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org,
jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org
Subject: Re: [PATCH v2] infiniband-diags: add rdma-ndd daemon
Date: Tue, 04 Nov 2014 14:32:13 +0100 [thread overview]
Message-ID: <5458D55D.4080501@acm.org> (raw)
In-Reply-To: <1414780065-15267-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On 10/31/14 19:27, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
> + format_specifier = 0;
> + for (tmp = node_desc; tmp[0] != '\0'; tmp++) {
> + if (tmp[0] == '%' && tmp[1] == 'h') {
> + format_specifier = 1;
> + break;
> + }
> + }
Hello Ira,
Sorry that I hadn't noticed this before but I think the above code can
be simplified into "format_specifier = !!strstr(node_desc, "%h")". With
or without that change, if you want you can add:
Reviewed-by: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-04 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 18:27 [PATCH v2] infiniband-diags: add rdma-ndd daemon ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1414780065-15267-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-04 13:32 ` Bart Van Assche [this message]
2014-11-07 12:17 ` Hal Rosenstock
[not found] ` <545CB84F.1070808-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-11-09 23:15 ` Weiny, Ira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5458D55D.4080501@acm.org \
--to=bvanassche-hinycgiudog@public.gmane.org \
--cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox