Re: [PATCHv2] libibmad: Add new fields for SM:PortInfoExtended and for PM:PortExtendedSpeedsCounters

Hal Rosenstock
2014-11-09T06:33:02Z

On 11/8/2014 9:29 AM, Weiny, Ira wrote:
>> --- a/src/fields.c
>> > +++ b/src/fields.c
>> > @@ -949,8 +949,42 @@ static const ib_field_t ib_mad_f[] = {
>> > {480, 32, "Counter14", mad_dump_uint},
>> > {0, 0}, /* IB_PSR_LAST_F */
>> >
>> > - {0, 0} /* IB_FIELD_LAST_ */
>> > + /*
>> > + * PortInfoExtended fields
>> > + */
>> > + {0, 32, "CapMask", mad_dump_hex},
> I'm not quite sure why the spec was written this way but technically CapMask is only 1 bit???

PortInfoExtended:CapMask is 32 bit field. Current 1.3 draft is
misformatted. The two rows are supposed to be combined into 1 and things
are misaligned. IsFECModeSupported is 1 bit (first bit out of those 32
bits).

> Therefore I'm not sure we can define this field as above. Can we get some assurances from the management WG
> that the 31 bit reserved field following the CapMask are only going to extend the CapMask?