RE: [PATCHv2] libibmad: Add new fields for SM:PortInfoExtended and for PM:PortExtendedSpeedsCounters

Weiny, Ira
2014-11-09T22:48:47Z

> On 11/8/2014 9:29 AM, Weiny, Ira wrote:
> >> --- a/src/fields.c
> >> > +++ b/src/fields.c
> >> > @@ -949,8 +949,42 @@ static const ib_field_t ib_mad_f[] = {
> >> > {480, 32, "Counter14", mad_dump_uint},
> >> > {0, 0}, /* IB_PSR_LAST_F */
> >> >
> >> > - {0, 0} /* IB_FIELD_LAST_ */
> >> > + /*
> >> > + * PortInfoExtended fields
> >> > + */
> >> > + {0, 32, "CapMask", mad_dump_hex},
> > I'm not quite sure why the spec was written this way but technically CapMask
> is only 1 bit???
>
> PortInfoExtended:CapMask is 32 bit field. Current 1.3 draft is misformatted.

Thanks... That makes more sense. Sorry I only just got access to the new 1.3 draft.

-- Ira

> The two rows are supposed to be combined into 1 and things are misaligned.
> IsFECModeSupported is 1 bit (first bit out of those 32 bits).
>
> > Therefore I'm not sure we can define this field as above. Can we get
> > some assurances from the management WG that the 31 bit reserved field
> following the CapMask are only going to extend the CapMask?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body
> of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html