From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Chuck Lever <chucklever-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 07/10] xprtrdma: Display async errors
Date: Tue, 11 Nov 2014 20:49:23 +0200 [thread overview]
Message-ID: <54625A33.6000506@dev.mellanox.co.il> (raw)
In-Reply-To: <1D304B95-D745-42B2-9324-143A5002FB35-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 11/11/2014 6:52 PM, Chuck Lever wrote:
>
>> On Nov 11, 2014, at 8:30 AM, Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> wrote:
>>
>>> On 11/9/2014 3:15 AM, Chuck Lever wrote:
>>> An async error upcall is a hard error, and should be reported in
>>> the system log.
>>>
>>
>> Could be useful to others... Any chance you put this in ib_core for all
>> of us?
>
> Eventually. We certainly wouldn't want copies of this array of strings
> to appear many times in the kernel. That would be a waste of space.
>
> I have a similar patch that adds an array for CQ status codes, and
> xprtrdma has a string array already for connection status. Are those
> also interesting?
>
Yep, also RDMA_CM events. Would certainly help people avoid source
code navigation to understand what is going on...
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-11 18:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-09 1:14 [PATCH v2 00/10] NFS/RDMA patches for 3.19 Chuck Lever
[not found] ` <20141109010328.8806.5861.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2014-11-09 1:14 ` [PATCH v2 01/10] xprtrdma: Return an errno from rpcrdma_register_external() Chuck Lever
2014-11-09 1:14 ` [PATCH v2 02/10] xprtrdma: Cap req_cqinit Chuck Lever
[not found] ` <20141109011420.8806.1849.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2014-11-09 10:13 ` Sagi Grimberg
[not found] ` <545F3E46.9040703-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-11-09 21:43 ` Chuck Lever
2014-11-09 1:14 ` [PATCH v2 03/10] xprtrdma: unmap all FMRs during transport disconnect Chuck Lever
2014-11-09 1:14 ` [PATCH v2 04/10] xprtrdma: Refactor tasklet scheduling Chuck Lever
2014-11-09 1:14 ` [PATCH v2 05/10] xprtrdma: Re-write rpcrdma_flush_cqs() Chuck Lever
2014-11-09 1:14 ` [PATCH v2 06/10] xprtrdma: Enable pad optimization Chuck Lever
[not found] ` <20141109011453.8806.31817.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2014-11-10 14:36 ` Anna Schumaker
[not found] ` <5460CD53.1080301-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
2014-11-10 14:54 ` Chuck Lever
[not found] ` <89410A6C-693C-4FB2-A0AB-5698803F3AFC-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2014-11-10 15:05 ` J. Bruce Fields
2014-11-09 1:15 ` [PATCH v2 07/10] xprtrdma: Display async errors Chuck Lever
[not found] ` <20141109011501.8806.23478.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2014-11-11 14:30 ` Sagi Grimberg
[not found] ` <54621D8D.7050508-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-11-11 16:52 ` Chuck Lever
[not found] ` <1D304B95-D745-42B2-9324-143A5002FB35-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-11 18:49 ` Sagi Grimberg [this message]
[not found] ` <54625A33.6000506-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-11-11 20:30 ` Or Gerlitz
2014-11-09 1:15 ` [PATCH v2 08/10] SUNRPC: serialize iostats updates Chuck Lever
2014-11-09 1:15 ` [PATCH v2 09/10] NFS: SETCLIENTID XDR buffer sizes are incorrect Chuck Lever
[not found] ` <20141109011518.8806.36904.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2014-11-10 15:22 ` Anna Schumaker
[not found] ` <5460D84A.3050704-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
2014-11-10 16:21 ` Trond Myklebust
2014-11-09 1:15 ` [PATCH v2 10/10] NFS: Clean up nfs4_init_callback() Chuck Lever
2014-11-26 16:25 ` [PATCH v2 00/10] NFS/RDMA patches for 3.19 Anna Schumaker
[not found] ` <5475FEFD.8070302-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
2014-11-26 16:36 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54625A33.6000506@dev.mellanox.co.il \
--to=sagig-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=chucklever-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox