From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH v2 07/10] xprtrdma: Display async errors Date: Tue, 11 Nov 2014 20:49:23 +0200 Message-ID: <54625A33.6000506@dev.mellanox.co.il> References: <20141109010328.8806.5861.stgit@manet.1015granger.net> <20141109011501.8806.23478.stgit@manet.1015granger.net> <54621D8D.7050508@dev.mellanox.co.il> <1D304B95-D745-42B2-9324-143A5002FB35@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1D304B95-D745-42B2-9324-143A5002FB35-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chuck Lever Cc: Chuck Lever , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 11/11/2014 6:52 PM, Chuck Lever wrote: > >> On Nov 11, 2014, at 8:30 AM, Sagi Grimberg wrote: >> >>> On 11/9/2014 3:15 AM, Chuck Lever wrote: >>> An async error upcall is a hard error, and should be reported in >>> the system log. >>> >> >> Could be useful to others... Any chance you put this in ib_core for all >> of us? > > Eventually. We certainly wouldn't want copies of this array of strings > to appear many times in the kernel. That would be a waste of space. > > I have a similar patch that adds an array for CQ status codes, and > xprtrdma has a string array already for connection status. Are those > also interesting? > Yep, also RDMA_CM events. Would certainly help people avoid source code navigation to understand what is going on... -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html