public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jackm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH V1 for-next 0/2] HW Device hot-removal support
Date: Tue, 18 Nov 2014 16:43:44 +0200	[thread overview]
Message-ID: <546B5B20.8090902@mellanox.com> (raw)
In-Reply-To: <1416312682-7899-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

On 11/18/2014 2:11 PM, Yishai Hadas wrote:
> Changes from V0:
> patch #1: ib_uverbs_close, reduced mutex scope to enable tasks run in parallel.

Yishai, still some things to sort out here...1st, there must be away for 
us to come up with two patches that do not introduce 55 "line over 80 
characters" new checkaptch warnings on the code. Next, there are few 
more checkpatch warnings, please fix them up.

# ./scripts/checkpatch.pl --strict /tmp/disc_v1/* | grep WARN  | wc -l
59

# ./scripts/checkpatch.pl --strict /tmp/disc_v1/* | grep WARN  | grep 
"line over" | wc -l
55

# ./scripts/checkpatch.pl --strict /tmp/disc_v1/* | grep WARN  | sort -u
WARNING: line over 80 characters
WARNING: msleep < 20ms can sleep for up to 20ms; see 
Documentation/timers/timers-howto.txt
WARNING: sizeof *context should be sizeof(*context)
WARNING: sizeof *ev_file should be sizeof(*ev_file)
WARNING: sizeof *file should be sizeof(*file)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2014-11-18 14:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18 12:11 [PATCH V1 for-next 0/2] HW Device hot-removal support Yishai Hadas
     [not found] ` <1416312682-7899-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-11-18 12:11   ` [PATCH V1 for-next 1/2] IB/uverbs: Enable device removal when there are active user space applications Yishai Hadas
     [not found]     ` <1416312682-7899-2-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-11-18 14:38       ` Or Gerlitz
     [not found]         ` <546B59E2.2050707-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-11-18 16:24           ` Yishai Hadas
     [not found]             ` <546B72A1.2080403-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-11-18 21:42               ` Or Gerlitz
     [not found]                 ` <CAJ3xEMh5f-qZuYQ30frjUa0ETNxexh2igguxxRm-pVtERCwn-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-19  8:05                   ` Or Gerlitz
2014-11-18 14:40       ` Or Gerlitz
2014-11-19 14:49       ` Or Gerlitz
     [not found]         ` <546CADEF.6070905-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-11-20  7:52           ` Yishai Hadas
     [not found]             ` <546D9DB2.8050900-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-11-20 11:21               ` Or Gerlitz
2014-11-20 11:21               ` Or Gerlitz
2014-11-18 12:11   ` [PATCH V1 for-next 2/2] IB/mlx4_ib: Disassociate support Yishai Hadas
     [not found]     ` <1416312682-7899-3-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-11-18 14:42       ` Or Gerlitz
     [not found]         ` <546B5AE3.9060606-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-11-18 16:48           ` Steve Wise
2014-11-18 17:14           ` Yishai Hadas
     [not found]             ` <546B7E73.40008-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-11-18 21:50               ` Or Gerlitz
     [not found]                 ` <CAJ3xEMjzZdf_aML2e+ht=cbYx3T9U7Lr7DOR6+JenEKTcxQ+Zw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-19 12:15                   ` Yishai Hadas
     [not found]                     ` <546C89E6.1000204-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2014-11-19 14:45                       ` Or Gerlitz
2014-11-18 14:43   ` Or Gerlitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546B5B20.8090902@mellanox.com \
    --to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=jackm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox