[PATCH] iw_cxgb4: Wake up waiters after flushing the qp

[PATCH] iw_cxgb4: Wake up waiters after flushing the qp

[Steve Wise]

When transitioning into ERROR state, the QP was getting flushed after
waking up any waiters.  This can cause applications to miss flushed work
requests which can stall an NFS mount.

Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
---

 drivers/infiniband/hw/cxgb4/qp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
index 41cd688..fad4851 100644
--- a/drivers/infiniband/hw/cxgb4/qp.c
+++ b/drivers/infiniband/hw/cxgb4/qp.c
@@ -1538,9 +1538,9 @@ err:
 	set_state(qhp, C4IW_QP_STATE_ERROR);
 	free = 1;
 	abort = 1;
-	wake_up(&qhp->wait);
 	BUG_ON(!ep);
 	flush_qp(qhp);
+	wake_up(&qhp->wait);
 out:
 	mutex_unlock(&qhp->mutex);
 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] iw_cxgb4: Wake up waiters after flushing the qp

[Steve Wise]

Hey Roland,

Hope you can get this bug fix into 3.18.  Plus these others that have 
been submitted a while ago.  Here is the entire list:

https://patchwork.kernel.org/patch/5106541/
https://patchwork.kernel.org/patch/5249511/
https://patchwork.kernel.org/patch/5249501/
https://patchwork.kernel.org/patch/5089511/
https://patchwork.kernel.org/patch/5089501/


Thanks,

Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] iw_cxgb4: Wake up waiters after flushing the qp

[Steve Wise]

I've pushed these to:

git://git.openfabrics.org/~swise/linux.git for_roland

Steve

Hariprasad Shenai (2):
      iw_cxgb4: Fixes locking issue in process_mpa_request
      iw_cxgb4: limit MRs to < 8GB for T4/T5 devices

Pramod Kumar (2):
      cxgb4/rdma:Increase epd buff size for debug interface
      cxgb4/rdma: configure 0B MRs to match HW implementation

Steve Wise (1):
      iw_cxgb4: Wake up waiters after flushing the qp


> -----Original Message-----
> From: Steve Wise [mailto:swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org]
> Sent: Friday, November 21, 2014 9:26 AM
> To: roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org
> Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: Re: [PATCH] iw_cxgb4: Wake up waiters after flushing the qp
> 
> Hey Roland,
> 
> Hope you can get this bug fix into 3.18.  Plus these others that have
> been submitted a while ago.  Here is the entire list:
> 
> https://patchwork.kernel.org/patch/5106541/
> https://patchwork.kernel.org/patch/5249511/
> https://patchwork.kernel.org/patch/5249501/
> https://patchwork.kernel.org/patch/5089511/
> https://patchwork.kernel.org/patch/5089501/
> 
> 
> Thanks,
> 
> Steve.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] iw_cxgb4: Wake up waiters after flushing the qp

[Steve Wise]

Hey Roland, please reply and let me know if you will push these to 3.18 (would have to happen now) or if they are destined for 3.19.

Thanks,

Steve.


> -----Original Message-----
> From: Steve Wise [mailto:swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org]
> Sent: Friday, November 21, 2014 9:42 AM
> To: 'roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org'
> Cc: 'linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org'
> Subject: RE: [PATCH] iw_cxgb4: Wake up waiters after flushing the qp
> 
> I've pushed these to:
> 
> git://git.openfabrics.org/~swise/linux.git for_roland
> 
> Steve
> 
> Hariprasad Shenai (2):
>       iw_cxgb4: Fixes locking issue in process_mpa_request
>       iw_cxgb4: limit MRs to < 8GB for T4/T5 devices
> 
> Pramod Kumar (2):
>       cxgb4/rdma:Increase epd buff size for debug interface
>       cxgb4/rdma: configure 0B MRs to match HW implementation
> 
> Steve Wise (1):
>       iw_cxgb4: Wake up waiters after flushing the qp
> 
> 
> > -----Original Message-----
> > From: Steve Wise [mailto:swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org]
> > Sent: Friday, November 21, 2014 9:26 AM
> > To: roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org
> > Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Subject: Re: [PATCH] iw_cxgb4: Wake up waiters after flushing the qp
> >
> > Hey Roland,
> >
> > Hope you can get this bug fix into 3.18.  Plus these others that have
> > been submitted a while ago.  Here is the entire list:
> >
> > https://patchwork.kernel.org/patch/5106541/
> > https://patchwork.kernel.org/patch/5249511/
> > https://patchwork.kernel.org/patch/5249501/
> > https://patchwork.kernel.org/patch/5089511/
> > https://patchwork.kernel.org/patch/5089501/
> >
> >
> > Thanks,
> >
> > Steve.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html