From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CCCA28BAB0 for ; Thu, 22 May 2025 13:44:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747921443; cv=none; b=V30TENmjXa+w4536HcBtgh+shO0VD4CCSS/l59e8pzdReXNWnc9hBbPKhsg3UV+5+in4j00mYj4FlTCtxNSWsbDhsqReeSA5N2sNIOSoGZQD9g/HwWcxsID5PSvL5v7zAsyDGWsSlSmWVj+60+C03GhON0fZLZlGCnZp3OE7Q9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747921443; c=relaxed/simple; bh=lOPj/8aEtz2b2Ko1osNQcdpCoFX+bMxSpLQVesnLlsc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NGYD3G2OQsVcX3/a9e0LyOrcMQY5WaPAHZwOiREhVBz9lld4xfn2kNVel0wwrFiv1uiVRiV4NTNyggKWhbVrtptjYkrpA+TEak6ECQysn+oPbs1WPbcrbWgVpkDWGoIiMyhZUoHBcvKjX8fAW3nm4w0hVgPJsWZXeRKliwqyh/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Xjo+UTIW; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Xjo+UTIW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747921439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7JgMDdO4BBC7QOqJWwaBEFuHvFQmR5tQPNMBjo6myTE=; b=Xjo+UTIWTNmwl7McRbwUQ6t6hjE/2VqwoWKliv//PwLIYXNoZlTuP3Fy9B4Rz/cN+PdezS T3CXjdj4oUrM9OMF3rzknl5YkxEdeTJEskhxphIKoTUIZGnz/t+1ZNOxoZLBMc9kzn0Z9V XZHJN9qPMfJRSNbwE9xkwbvh6ua/+Ro= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-QHAB265HPAm87EcJqpyHPg-1; Thu, 22 May 2025 09:43:56 -0400 X-MC-Unique: QHAB265HPAm87EcJqpyHPg-1 X-Mimecast-MFC-AGG-ID: QHAB265HPAm87EcJqpyHPg_1747921436 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43d007b2c79so60647285e9.2 for ; Thu, 22 May 2025 06:43:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747921435; x=1748526235; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7JgMDdO4BBC7QOqJWwaBEFuHvFQmR5tQPNMBjo6myTE=; b=m9fKr+aKH/Gdtw0WNdINxHQrr7VsETs5+FHyXxxQXzV02eu/03k/LW/xvEN+xxljWC M+1OlmYqlNdH1cBqj7PGcFI994mRPT/R/wlt+N8apxuxKVf7IVRRzS6U7WcQXy+L+qBM el8veO8xUGsDhqwxMtn87b444I+LolOSUPp+7U7T7N2IAHswwLFcwisfdRDCYLF29i2M sP3duoOmXp9a37ND3CmO/GndLqZOxw+n8ecqw1S6sD6Tk3locSFJkxDR5CkNjQur8TL2 Rm8uJ32xFc4icGbar2d3A/sbMMxss1V+rvGobp/qNP7qy/hMiZUsxhNd+nEqgfNhSZiq L4Cg== X-Forwarded-Encrypted: i=1; AJvYcCW6tJ98wMKsQz+jMYTsfC5Z2W1hR+/6c/wtDt0hP15VUg8Lg6QV+e7zV0ZVWQnSTsotlc2GttkAg0vu@vger.kernel.org X-Gm-Message-State: AOJu0YwIYHI6dao425Ba4Cb6eJzQZAscxiSDjXD/tPp4VZw7HyLhi2ci SEf1faCZCAibfPGuI9AEVjLdwzhOq0FFYAdV4wtc1WoQIqOAj6197HyZXc4T+DX0AxX9PJe0S/u bo4AMJrTxzdOj4DwFl2LI9UxJmMP+aHQHRnoF3dSwrCMIZjQo8KzdoMLHL9HhDaA= X-Gm-Gg: ASbGncvSmzS0nGrsVf3HyBgQRKzr/qfx2YRcN9EUMgRqCeUcnT8p7ScG8AarlRHZ3iR +QJV28tEOln5GjbFrqpqEERtDAUUUGmTgpZFmeJZtjyk5VD5sFyVUYtVEx04Fg1I2HUp81sQV3s iEjuQh3kyD95QjK+wXX1l+M+Fil2l6Kl+GIGaDH6bIp66NjVI7aCHZWdsH/IJe79GdeWv77lZ0N Z7ZnPwM8go6eQBLGddTNElxFVvndp1UIcYej/FyxO9zJg1zSjStZvtHh0Pu/5wkyE9XFajxLE7y h9H//b5TpH2PUbEI7O0= X-Received: by 2002:a05:600c:64cd:b0:43d:745a:5a50 with SMTP id 5b1f17b1804b1-442fd6313demr193274845e9.19.1747921435610; Thu, 22 May 2025 06:43:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGSrKn8LA5eHA5OxHAPqACQvxGAtPFpq+CamWhPoSdiOYmSKeWiKQJ2+X7B9tot/wDyu9PvNA== X-Received: by 2002:a05:600c:64cd:b0:43d:745a:5a50 with SMTP id 5b1f17b1804b1-442fd6313demr193274635e9.19.1747921435208; Thu, 22 May 2025 06:43:55 -0700 (PDT) Received: from ?IPV6:2a0d:3344:247a:1010::f39? ([2a0d:3344:247a:1010::f39]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f73d3d6csm109001055e9.19.2025.05.22.06.43.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 May 2025 06:43:54 -0700 (PDT) Message-ID: <5470f2d2-d3cb-4451-b8e8-5ee768ed9741@redhat.com> Date: Thu, 22 May 2025 15:43:52 +0200 Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [EXTERNAL] Re: [PATCH net-next,v2] net: mana: Add support for Multi Vports on Bare metal To: Simon Horman , Haiyang Zhang Cc: "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , Dexuan Cui , "stephen@networkplumber.org" , KY Srinivasan , Paul Rosswurm , "olaf@aepfle.de" , "vkuznets@redhat.com" , "davem@davemloft.net" , "wei.liu@kernel.org" , "edumazet@google.com" , "kuba@kernel.org" , "leon@kernel.org" , Long Li , "ssengar@linux.microsoft.com" , "linux-rdma@vger.kernel.org" , "daniel@iogearbox.net" , "john.fastabend@gmail.com" , "bpf@vger.kernel.org" , "ast@kernel.org" , "hawk@kernel.org" , "tglx@linutronix.de" , "shradhagupta@linux.microsoft.com" , "andrew+netdev@lunn.ch" , Konstantin Taranov , "linux-kernel@vger.kernel.org" References: <1747671636-5810-1-git-send-email-haiyangz@microsoft.com> <20250521140231.GW365796@horms.kernel.org> <20250522120229.GX365796@horms.kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250522120229.GX365796@horms.kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/22/25 2:02 PM, Simon Horman wrote: > On Wed, May 21, 2025 at 05:28:33PM +0000, Haiyang Zhang wrote: >>> -----Original Message----- >>> From: Simon Horman >>> Sent: Wednesday, May 21, 2025 10:03 AM >>> To: Haiyang Zhang >>> Cc: linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; Dexuan Cui >>> ; stephen@networkplumber.org; KY Srinivasan >>> ; Paul Rosswurm ; >>> olaf@aepfle.de; vkuznets@redhat.com; davem@davemloft.net; >>> wei.liu@kernel.org; edumazet@google.com; kuba@kernel.org; >>> pabeni@redhat.com; leon@kernel.org; Long Li ; >>> ssengar@linux.microsoft.com; linux-rdma@vger.kernel.org; >>> daniel@iogearbox.net; john.fastabend@gmail.com; bpf@vger.kernel.org; >>> ast@kernel.org; hawk@kernel.org; tglx@linutronix.de; >>> shradhagupta@linux.microsoft.com; andrew+netdev@lunn.ch; Konstantin >>> Taranov ; linux-kernel@vger.kernel.org >>> Subject: [EXTERNAL] Re: [PATCH net-next,v2] net: mana: Add support for >>> Multi Vports on Bare metal >>> >>> On Mon, May 19, 2025 at 09:20:36AM -0700, Haiyang Zhang wrote: >>>> To support Multi Vports on Bare metal, increase the device config >>> response >>>> version. And, skip the register HW vport, and register filter steps, >>> when >>>> the Bare metal hostmode is set. >>>> >>>> Signed-off-by: Haiyang Zhang >>>> --- >>>> v2: >>>> Updated comments as suggested by ALOK TIWARI. >>>> Fixed the version check. >>>> >>>> --- >>>> drivers/net/ethernet/microsoft/mana/mana_en.c | 24 ++++++++++++------- >>>> include/net/mana/mana.h | 4 +++- >>>> 2 files changed, 19 insertions(+), 9 deletions(-) >>>> >>>> diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c >>> b/drivers/net/ethernet/microsoft/mana/mana_en.c >>>> index 2bac6be8f6a0..9c58d9e0bbb5 100644 >>>> --- a/drivers/net/ethernet/microsoft/mana/mana_en.c >>>> +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c >>>> @@ -921,7 +921,7 @@ static void mana_pf_deregister_filter(struct >>> mana_port_context *apc) >>>> >>>> static int mana_query_device_cfg(struct mana_context *ac, u32 >>> proto_major_ver, >>>> u32 proto_minor_ver, u32 proto_micro_ver, >>>> - u16 *max_num_vports) >>>> + u16 *max_num_vports, u8 *bm_hostmode) >>>> { >>>> struct gdma_context *gc = ac->gdma_dev->gdma_context; >>>> struct mana_query_device_cfg_resp resp = {}; >>>> @@ -932,7 +932,7 @@ static int mana_query_device_cfg(struct mana_context >>> *ac, u32 proto_major_ver, >>>> mana_gd_init_req_hdr(&req.hdr, MANA_QUERY_DEV_CONFIG, >>>> sizeof(req), sizeof(resp)); >>>> >>>> - req.hdr.resp.msg_version = GDMA_MESSAGE_V2; >>>> + req.hdr.resp.msg_version = GDMA_MESSAGE_V3; >>>> >>>> req.proto_major_ver = proto_major_ver; >>>> req.proto_minor_ver = proto_minor_ver; >>> >>>> @@ -956,11 +956,16 @@ static int mana_query_device_cfg(struct >>> mana_context *ac, u32 proto_major_ver, >>>> >>>> *max_num_vports = resp.max_num_vports; >>>> >>>> - if (resp.hdr.response.msg_version == GDMA_MESSAGE_V2) >>>> + if (resp.hdr.response.msg_version >= GDMA_MESSAGE_V2) >>>> gc->adapter_mtu = resp.adapter_mtu; >>>> else >>>> gc->adapter_mtu = ETH_FRAME_LEN; >>>> >>>> + if (resp.hdr.response.msg_version >= GDMA_MESSAGE_V3) >>>> + *bm_hostmode = resp.bm_hostmode; >>>> + else >>>> + *bm_hostmode = 0; >>> >>> Hi, >>> >>> Perhaps not strictly related to this patch, but I see >>> that mana_verify_resp_hdr() is called a few lines above. >>> And that verifies a minimum msg_version. But I do not see >>> any verification of the maximum msg_version supported by the code. >>> >>> I am concerned about a hypothetical scenario where, say the as yet unknown >>> version 5 is sent as the version, and the above behaviour is used, while >>> not being correct. >>> >>> Could you shed some light on this? >>> >> >> In driver, we specify the expected reply msg version is v3 here: >> req.hdr.resp.msg_version = GDMA_MESSAGE_V3; >> >> If the HW side is upgraded, it won't send reply msg version higher >> than expected, which may break the driver. > > Thanks, > > If I understand things correctly the HW side will honour the > req.hdr.resp.msg_version and thus the SW won't receive anything > it doesn't expect. Is that right? @Haiyang, if Simon's interpretation is correct, please change the version checking in the driver from: if (resp.hdr.response.msg_version >= GDMA_MESSAGE_V3) to if (resp.hdr.response.msg_version == GDMA_MESSAGE_V3) As the current code is misleading. Thanks, Paolo