Re: [RFC PATCH 07/16] ib/mad: create a jumbo MAD kmem_cache

[Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

On 11/13/2014 9:54 PM, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
> @@ -773,7 +782,12 @@ static int handle_outgoing_dr_smp(struct ib_mad_agent_private *mad_agent_priv,
>   	}
>   	local->mad_priv = NULL;
>   	local->recv_mad_agent = NULL;
> -	mad_priv = kmem_cache_alloc(ib_mad_cache, GFP_ATOMIC);
> +
> +	if (mad_agent_priv->qp_info->supports_jumbo_mads)
> +		mad_priv = kmem_cache_alloc(jumbo_mad_cache, GFP_ATOMIC);
> +	else
> +		mad_priv = kmem_cache_alloc(ib_mad_cache, GFP_ATOMIC);
> +
@ minimum (if you really think that one kmem cache for both jumbo and 
non-jumbo mads
isn't the way to get) lets have one pointer that is directed to the 
cache you want to use and this
way all branch as the above one and it's such can be avoided, right?

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html