From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 2/2] ib_srpt: convert printk's to pr_* functions
Date: Fri, 28 Nov 2014 10:07:42 +0100 [thread overview]
Message-ID: <54783B5E.10803@acm.org> (raw)
In-Reply-To: <5f85bfc1e69ebb8dcd8c048d3a3a6bf135f5fc36.1413847199.git.dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 10/21/14 01:24, Doug Ledford wrote:
> The driver already defined the pr_format, it just hadn't
> been converted to use pr_info, pr_warn, and pr_err instead
> of the equivalent printks. Convert so that messages from
> the driver are now properly tagged with their driver name
> and can be more easily debugged.
>
> In addition, a number of these printk's were not newline
> terminated, so fix that at the same time.
>
> Signed-off-by: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
The second hunk of this patch does not apply on kernel v3.18-rc6.
Anyway, if you want you can add:
Reviewed-by: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-11-28 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 23:24 [PATCH 0/2] Minor patches previous missed Doug Ledford
[not found] ` <cover.1413847199.git.dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-10-20 23:24 ` [PATCH 1/2] IB/srp: Use P_Key cache for P_Key lookups Doug Ledford
2014-10-20 23:24 ` [PATCH 2/2] ib_srpt: convert printk's to pr_* functions Doug Ledford
[not found] ` <5f85bfc1e69ebb8dcd8c048d3a3a6bf135f5fc36.1413847199.git.dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-11-28 9:07 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54783B5E.10803@acm.org \
--to=bvanassche-hinycgiudog@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox