public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Vangelis Tasoulas <vangelis-S8y2klWGCOFhl2p70BpVqQ@public.gmane.org>
Cc: Linux RDMA Mailing List
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: assertion failed in osm_switch_get_lft_block() function
Date: Sat, 20 Dec 2014 08:08:16 -0500	[thread overview]
Message-ID: <549574C0.8030001@dev.mellanox.co.il> (raw)
In-Reply-To: <54948EB7.1020706-S8y2klWGCOFhl2p70BpVqQ@public.gmane.org>

On 12/19/2014 3:46 PM, Vangelis Tasoulas wrote:
> Hello,
> 
> When I use LIDs from the top LFT block (0xbfc0-0xbfff), I get an
> assertion error from the function osm_switch_get_lft_block() which is
> implemented in osm_switch.c.
> 
> The line is this one:
> CL_ASSERT(base_lid_ho + IB_SMP_DATA_SIZE <= IB_LID_UCAST_END_HO);
> 
> In the topmost LFT block, the base_lid_ho has the value 49088 and the
> IB_SMP_DATA_SIZE is 64. Together they add up to 49152 but the assertion
> checks if they are less than 0xbfff (49151).
> 
> Shouldn't this line be something like the following?
> 
> CL_ASSERT(base_lid_ho + IB_SMP_DATA_SIZE - 1 <= IB_LID_UCAST_END_HO);
> 
> or
> 
> CL_ASSERT(base_lid_ho + IB_SMP_DATA_SIZE <= IB_LID_UCAST_END_HO + 1);

Yes. Would you issue patch for this ?

Thanks.

-- Hal

> Cheers,
> Vangelis
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2014-12-20 13:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19 20:46 assertion failed in osm_switch_get_lft_block() function Vangelis Tasoulas
     [not found] ` <54948EB7.1020706-S8y2klWGCOFhl2p70BpVqQ@public.gmane.org>
2014-12-20 13:08   ` Hal Rosenstock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549574C0.8030001@dev.mellanox.co.il \
    --to=hal-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vangelis-S8y2klWGCOFhl2p70BpVqQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox