* [PATCHv2 libibmad] fields.c: Print SwitchCongestionSetting threshold fields in hex rather than decimal
@ 2015-01-09 11:06 Hal Rosenstock
[not found] ` <54AFB622.2010301-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Hal Rosenstock @ 2015-01-09 11:06 UTC (permalink / raw)
To: Ira Weiny
Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
Chu, Al
for consistency with CC Annex which shows meaning of threshold fields in hex not decimal
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
Change since v1:
Change fields to hex rather than SwitchPortCongestionSetting:Threshold to be consistent with CC Annex
diff --git a/src/fields.c b/src/fields.c
index 33a6364..9965811 100644
--- a/src/fields.c
+++ b/src/fields.c
@@ -858,9 +858,9 @@ static const ib_field_t ib_mad_f[] = {
{0, 32, "Control_Map", mad_dump_hex},
{32, 256, "Victim_Mask", mad_dump_array},
{288, 256, "Credit_Mask", mad_dump_array},
- {BITSOFFS(544, 4), "Threshold", mad_dump_uint},
+ {BITSOFFS(544, 4), "Threshold", mad_dump_hex},
{BITSOFFS(552, 8), "Packet_Size", mad_dump_uint},
- {BITSOFFS(560, 4), "CS_Threshold", mad_dump_uint},
+ {BITSOFFS(560, 4), "CS_Threshold", mad_dump_hex},
{BITSOFFS(576, 16), "CS_ReturnDelay", mad_dump_hex}, /* TODO: CCT dump */
{BITSOFFS(592, 16), "Marking_Rate", mad_dump_uint},
{0, 0}, /* IB_CC_SWITCH_CONGESTION_SETTING_LAST_F */
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCHv2 libibmad] fields.c: Print SwitchCongestionSetting threshold fields in hex rather than decimal
[not found] ` <54AFB622.2010301-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2015-01-09 23:36 ` Weiny, Ira
0 siblings, 0 replies; 2+ messages in thread
From: Weiny, Ira @ 2015-01-09 23:36 UTC (permalink / raw)
To: Hal Rosenstock
Cc: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org),
Chu, Al
> for consistency with CC Annex which shows meaning of threshold fields in hex
> not decimal
>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Thanks applied.
Ira
> ---
> Change since v1:
> Change fields to hex rather than SwitchPortCongestionSetting:Threshold to be
> consistent with CC Annex
>
> diff --git a/src/fields.c b/src/fields.c index 33a6364..9965811 100644
> --- a/src/fields.c
> +++ b/src/fields.c
> @@ -858,9 +858,9 @@ static const ib_field_t ib_mad_f[] = {
> {0, 32, "Control_Map", mad_dump_hex},
> {32, 256, "Victim_Mask", mad_dump_array},
> {288, 256, "Credit_Mask", mad_dump_array},
> - {BITSOFFS(544, 4), "Threshold", mad_dump_uint},
> + {BITSOFFS(544, 4), "Threshold", mad_dump_hex},
> {BITSOFFS(552, 8), "Packet_Size", mad_dump_uint},
> - {BITSOFFS(560, 4), "CS_Threshold", mad_dump_uint},
> + {BITSOFFS(560, 4), "CS_Threshold", mad_dump_hex},
> {BITSOFFS(576, 16), "CS_ReturnDelay", mad_dump_hex}, /* TODO: CCT
> dump */
> {BITSOFFS(592, 16), "Marking_Rate", mad_dump_uint},
> {0, 0}, /*
> IB_CC_SWITCH_CONGESTION_SETTING_LAST_F */
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-09 23:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-09 11:06 [PATCHv2 libibmad] fields.c: Print SwitchCongestionSetting threshold fields in hex rather than decimal Hal Rosenstock
[not found] ` <54AFB622.2010301-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-01-09 23:36 ` Weiny, Ira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox