[PATCH infiniband-diags] ibdiag_common.c: Add more supported device IDs

[PATCH infiniband-diags] ibdiag_common.c: Add more supported device IDs

[Hal Rosenstock]

Add support for ConnectX-3 and ConnectX-4. 

Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/src/ibdiag_common.c b/src/ibdiag_common.c
index 8c749c7..384d342 100644
--- a/src/ibdiag_common.c
+++ b/src/ibdiag_common.c
@@ -499,9 +499,9 @@ conv_cnt_human_readable(uint64_t val64, float *val, int data)
 int is_mlnx_ext_port_info_supported(uint32_t devid)
 {
 	if (ibd_ibnetdisc_flags & IBND_CONFIG_MLX_EPI) {
-		if (devid == 0xc738)
+		if (devid == 0xc738 || devid == 0xcb84)
 			return 1;
-		if (devid >= 0x1003 && devid <= 0x1011)
+		if (devid >= 0x1003 && devid <= 0x1016)
 			return 1;
 	}
 	return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH infiniband-diags] ibdiag_common.c: Add more supported device IDs

[Or Gerlitz]

On 1/12/2015 9:08 PM, Hal Rosenstock wrote:
> Add support for ConnectX-3 and ConnectX-4

So... ConnectX-3 isn't supported today?! on what infrastructure/tools 
exactly?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH infiniband-diags] ibdiag_common.c: Add more supported device IDs

[Hal Rosenstock]

On 1/13/2015 2:05 AM, Or Gerlitz wrote:
> On 1/12/2015 9:08 PM, Hal Rosenstock wrote:
>> Add support for ConnectX-3 and ConnectX-4
> 
> So... ConnectX-3 isn't supported today?! 

It's just device IDs 0x1012 and 0x1013.

> on what infrastructure/tools exactly?

This only affects tool(s) which invoke this routine
(is_mlnx_ext_port_info_supported) which is
currently just ibportstate.

is_mlnx_ext_port_info_supported determines whether or not the MLNX
vendor extended port info SMP is sent which is used to determine FDR10
speed.

Not having the device in the list would only result in FDR10 being
misinterpreted as QDR.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH infiniband-diags] ibdiag_common.c: Add more supported device IDs

[Or Gerlitz]

On 1/13/2015 3:09 PM, Hal Rosenstock wrote:
> On 1/13/2015 2:05 AM, Or Gerlitz wrote:
>> >On 1/12/2015 9:08 PM, Hal Rosenstock wrote:
>>> >>Add support for ConnectX-3 and ConnectX-4
>> >
>> >So... ConnectX-3 isn't supported today?!
> It's just device IDs 0x1012 and 0x1013
I don't see these devices in the mlx4 core driver PCI table 
(mlx4_pci_table in main.c) nor in libmlx4, not sure what you are 
referring to  here...

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html