From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH 02/20] IB/core: Cache device attributes for use by upper level drivers Date: Wed, 14 Jan 2015 08:08:50 +0200 Message-ID: <54B607F2.3020904@mellanox.com> References: <1421082672-22588-1-git-send-email-ira.weiny@intel.com> <1421082672-22588-3-git-send-email-ira.weiny@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1421082672-22588-3-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Cc: roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 1/12/2015 7:10 PM, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > From: Ira Weiny Please avoid empty change-logs, e.g one liner will perfectly do here. > Signed-off-by: Ira Weiny > --- > drivers/infiniband/core/device.c | 2 ++ > include/rdma/ib_verbs.h | 1 + > 2 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c > index 18c1ece..3a6afde 100644 > --- a/drivers/infiniband/core/device.c > +++ b/drivers/infiniband/core/device.c > @@ -294,6 +294,8 @@ int ib_register_device(struct ib_device *device, > spin_lock_init(&device->event_handler_lock); > spin_lock_init(&device->client_data_lock); > > + device->query_device(device, &device->attributes); > + > ret = read_port_table_lengths(device); > if (ret) { > printk(KERN_WARNING "Couldn't create table lengths cache for device %s\n", > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > index 0d74f1d..86fc90f 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -1675,6 +1675,7 @@ struct ib_device { > u32 local_dma_lkey; > u8 node_type; > u8 phys_port_cnt; > + struct ib_device_attr attributes; I think cached_dev_attrs will be better name. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html