RE: [PATCH 14/20] IB/core: Add IB_DEVICE_OPA_MAD_SUPPORT device cap flag

Weiny, Ira
2015-01-14T20:47:55Z

>
> On 1/12/2015 7:11 PM, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
> > Add a device capability flag to flag OPA MAD support on devices.
>
> You should put few words here telling what is OPA/OPA MADs and why
> supporting them fits the IB core.
>
> See for example the IB core patch [1] that added signature verbs API is states in
> a manner which is both generic across vendors and across different Mellanox
> HCAs. Also see [2] the IB core patch that added support for BMME API as
> another example.

I'm not quite sure what should be covered in this message which is different from the cover letter or the subsequent patches.

Would this be more acceptable?

<quote>

IB/core: Add IB_DEVICE_OPA_MAD_SUPPORT device cap flag

OPA MADs share a common header with IBTA MADs but with a different base version
and an extended length. These "jumbo" MADs increase the performance of
management traffic.

Sharing a common header with IBTA MADs allows us to share most of the MAD
processing code when dealing with OPA MADs in addition to supporting some IBTA
MADs on OPA devices.

Add a device capability flag to indicate OPA MAD support on the device.

</quote>

Ira

>
>
> [1] 1b01d33 IB/core: Introduce signature verbs API [2] 00f7ec3 RDMA/core:
> Add memory management extensions support