From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haggai Eran Subject: Re: [PATCH v3 06/17] IB/core: Add support for extended query device caps Date: Wed, 21 Jan 2015 13:14:59 +0200 Message-ID: <54BF8A33.1030308@mellanox.com> References: <1418310266-9584-1-git-send-email-haggaie@mellanox.com> <1418310266-9584-7-git-send-email-haggaie@mellanox.com> <1418733236.2779.26.camel@opteya.com> <1418760888.3245.29.camel@dworkin> <1421836353.13543.7.camel@opteya.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1421836353.13543.7.camel-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yann Droneaud , Or Gerlitz Cc: Roland Dreier , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Liran Liss , Or Gerlitz , Sagi Grimberg , Majd Dibbiny , Jerome Glisse , Eli Cohen List-Id: linux-rdma@vger.kernel.org On 21/01/2015 12:32, Yann Droneaud wrote: > Hi, >=20 > Le mardi 16 d=C3=A9cembre 2014 =C3=A0 21:14 +0100, Yann Droneaud a =C3= =A9crit : >> Le mardi 16 d=C3=A9cembre 2014 =C3=A0 22:07 +0200, Or Gerlitz a =C3=A9= crit : >>> On Tue, Dec 16, 2014 at 7:41 PM, Roland Dreier = wrote: >>>> On Tue, Dec 16, 2014 at 4:33 AM, Yann Droneaud wrote: >>>>> >>>>> With the suggested change here, buffer overflow won't happen, >>>>> but the error is silently ignored, allowing uverb to return a >>>>> partial result, which is likely not expected by userspace as >>>>> it's a bit difficult to handle it gracefully. >>>>> >>>>> So this has to be removed, and a check on userspace response >>>>> buffer must be added to ib_uverbs_ex_query_device() instead. >>>> >>>> I'm not sure of the specifics of the change you're suggesting here= =2E >>>> Would it be OK to go forward with the patch set we have, and then = fix >>>> this issue before 3.19-rc2? >>> >>> Roland, >>> >>> Haggai will address the change in an incremental patch against your >>> for-next (3.19-rc1) so the fix will be ready on time for 3.19-rc2 >>> >=20 > AFAICT, no fix has been posted on the list so far. > Do you have a patch to address the issue ready ? As I wrote before [1], I respectfully disagree with the change you proposed, and I think it would make the code less maintainable and most likely hurt backward compatibility in the future. [1] http://www.spinics.net/lists/linux-rdma/msg22403.html Regards, Haggai -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html