Re: [PATCH v3 06/17] IB/core: Add support for extended query device caps

Or Gerlitz
2014-12-16T20:07:29Z

On Tue, Dec 16, 2014 at 7:41 PM, Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Tue, Dec 16, 2014 at 4:33 AM, Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org> wrote:
>>
>> With the suggested change here, buffer overflow won't happen,
>> but the error is silently ignored, allowing uverb to return a
>> partial result, which is likely not expected by userspace as
>> it's a bit difficult to handle it gracefully.
>>
>> So this has to be removed, and a check on userspace response
>> buffer must be added to ib_uverbs_ex_query_device() instead.
>
> I'm not sure of the specifics of the change you're suggesting here.
> Would it be OK to go forward with the patch set we have, and then fix
> this issue before 3.19-rc2?

Roland,

Haggai will address the change in an incremental patch against your
for-next (3.19-rc1) so the fix will be ready on time for 3.19-rc2

Or.