From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haggai Eran Subject: Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache Date: Thu, 19 Feb 2015 17:03:51 +0200 Message-ID: <54E5FB57.1090803@mellanox.com> References: <1424383365-19337-1-git-send-email-somnath.kotur@emulex.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Somnath Kotur , roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Matan Barak List-Id: linux-rdma@vger.kernel.org On 20/02/2015 00:02, Somnath Kotur wrote: > @@ -502,9 +547,7 @@ EXPORT_SYMBOL(ib_create_qp); > static const struct { > int valid; > enum ib_qp_attr_mask req_param[IB_QPT_MAX]; > - enum ib_qp_attr_mask req_param_add_eth[IB_QPT_MAX]; > enum ib_qp_attr_mask opt_param[IB_QPT_MAX]; > - enum ib_qp_attr_mask opt_param_add_eth[IB_QPT_MAX]; > } qp_state_table[IB_QPS_ERR + 1][IB_QPS_ERR + 1] = { > [IB_QPS_RESET] = { > [IB_QPS_RESET] = { .valid = 1 }, > @@ -585,12 +628,6 @@ static const struct { > IB_QP_MAX_DEST_RD_ATOMIC | > IB_QP_MIN_RNR_TIMER), > }, > - .req_param_add_eth = { > - [IB_QPT_RC] = (IB_QP_SMAC), > - [IB_QPT_UC] = (IB_QP_SMAC), > - [IB_QPT_XRC_INI] = (IB_QP_SMAC), > - [IB_QPT_XRC_TGT] = (IB_QP_SMAC) > - }, > .opt_param = { > [IB_QPT_UD] = (IB_QP_PKEY_INDEX | > IB_QP_QKEY), > @@ -611,21 +648,7 @@ static const struct { > [IB_QPT_GSI] = (IB_QP_PKEY_INDEX | > IB_QP_QKEY), > }, > - .opt_param_add_eth = { > - [IB_QPT_RC] = (IB_QP_ALT_SMAC | > - IB_QP_VID | > - IB_QP_ALT_VID), > - [IB_QPT_UC] = (IB_QP_ALT_SMAC | > - IB_QP_VID | > - IB_QP_ALT_VID), > - [IB_QPT_XRC_INI] = (IB_QP_ALT_SMAC | > - IB_QP_VID | > - IB_QP_ALT_VID), > - [IB_QPT_XRC_TGT] = (IB_QP_ALT_SMAC | > - IB_QP_VID | > - IB_QP_ALT_VID) > - } > - } > + }, > }, > [IB_QPS_RTR] = { > [IB_QPS_RESET] = { .valid = 1 }, > @@ -847,13 +870,6 @@ int ib_modify_qp_is_ok(enum ib_qp_state cur_state, enum ib_qp_state next_state, > req_param = qp_state_table[cur_state][next_state].req_param[type]; > opt_param = qp_state_table[cur_state][next_state].opt_param[type]; > > - if (ll == IB_LINK_LAYER_ETHERNET) { > - req_param |= qp_state_table[cur_state][next_state]. > - req_param_add_eth[type]; > - opt_param |= qp_state_table[cur_state][next_state]. > - opt_param_add_eth[type]; > - } > - > if ((mask & req_param) != req_param) > return 0; > I understand this patch will remove any kernel reference to these modify_qp attributes. However, what about user-space? Was it previously allowed to pass in these parameters? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html