* [PATCH libibumad] umad.h: Remove umad_reg_flags from enum declaration
@ 2015-03-03 20:23 Hal Rosenstock
[not found] ` <54F61829.3070903-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Hal Rosenstock @ 2015-03-03 20:23 UTC (permalink / raw)
To: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
Cc: Ira Weiny, rafiw-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
This causes it to be a global variable which causes linking
issues when used by multiple files linked together. It results
in multiple definition of `umad_reg_flags'.
Found-by: Rafi Weiner <rafiw-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/include/infiniband/umad.h b/include/infiniband/umad.h
index 6c3e7dc..1db4505 100644
--- a/include/infiniband/umad.h
+++ b/include/infiniband/umad.h
@@ -201,7 +201,7 @@ int umad_unregister(int portid, int agentid);
enum {
UMAD_USER_RMPP = (1 << 0)
-} umad_reg_flags;
+};
struct umad_reg_attr {
uint8_t mgmt_class;
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH libibumad] umad.h: Remove umad_reg_flags from enum declaration
[not found] ` <54F61829.3070903-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2015-03-03 20:33 ` Weiny, Ira
0 siblings, 0 replies; 2+ messages in thread
From: Weiny, Ira @ 2015-03-03 20:33 UTC (permalink / raw)
To: Hal Rosenstock,
linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
Cc: rafiw-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
> -----Original Message-----
> From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-
> owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Hal Rosenstock
> Sent: Tuesday, March 03, 2015 12:23 PM
> To: linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
> Cc: Weiny, Ira; rafiw-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
> Subject: [PATCH libibumad] umad.h: Remove umad_reg_flags from enum
> declaration
>
>
> This causes it to be a global variable which causes linking issues when used by
> multiple files linked together. It results in multiple definition of
> `umad_reg_flags'.
>
> Found-by: Rafi Weiner <rafiw-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-03 20:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-03 20:23 [PATCH libibumad] umad.h: Remove umad_reg_flags from enum declaration Hal Rosenstock
[not found] ` <54F61829.3070903-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-03-03 20:33 ` Weiny, Ira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox