From: Michael Wang <yun.wang@profitbricks.com>
To: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
Roland Dreier <roland@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Ira Weiny <ira.weiny@intel.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
"David S. Miller" <davem@davemloft.net>,
Moni Shoua <monis@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Tatyana Nikolova <Tatyana.E.Nikolova@intel.com>,
Steve Wise <swise@opengridcomputing.com>,
Yan Burman <yanb@mellanox.com>,
Jack Morgenstein <jackm@dev.mellanox.co.il>,
Bart Van Assche <bvanassche@acm.org>,
Yann Droneaud <ydroneaud@opteya.com>,
Colin Ian King <colin.king@canonical.com>,
Jiri Kosina <jkosina@suse.cz>, Matan Barak <matanb@mellanox.com>,
Majd Dibbiny <majd@mellanox.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Mel Gorman <mgorman@suse.de>, Alex Estrin <alex.estrin@intel.com>,
Doug Ledford <dledford@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Erez Shitrit <erezsh@mellanox.com>,
Sagi Grimberg <sagig@mellanox.com>,
Haggai Eran <haggaie@mellanox.c>
Subject: [PATCH 0/2 RESEND] IB/Verbs: Use helpers to refine the checking on transport and link layer
Date: Wed, 25 Mar 2015 16:09:36 +0100 [thread overview]
Message-ID: <5512CFB0.1050108@profitbricks.com> (raw)
My sincerely apologies for the corrupted mails, and thanks for Dan's kindly
remind :-)
There are too many lengthy code to check the transport type of IB device,
or the link layer type of it's port, this patch set try to use some helper to
refine and save us some code.
TODO:
Currently we inferred from the transport type and link layer type to identify
the way of management, it will be better if we can directly get the indicator
from vendor.
Sean proposed one suggestion:
https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23339.html
It may need a big work to adapt current implementation to utilize
these flags elegantly.
Also the performance concern on query_port() need to be addressed, may be
some new callback like query_mgmt() could works.
Michael Wang (2):
[PATCH 1/2] IB/Verbs: Use helpers to check transport and link layer
[PATCH 2/2] IB/Verbs: Use helpers to check IBoE technology
---
drivers/infiniband/core/agent.c | 2 -
drivers/infiniband/core/cm.c | 2 -
drivers/infiniband/core/cma.c | 33 ++++++++++++------------------
drivers/infiniband/core/mad.c | 6 ++---
drivers/infiniband/core/multicast.c | 11 +++-------
drivers/infiniband/core/sa_query.c | 14 ++++++------
drivers/infiniband/core/ucm.c | 3 --
drivers/infiniband/core/user_mad.c | 2 -
drivers/infiniband/core/verbs.c | 5 +---
drivers/infiniband/hw/mlx4/ah.c | 2 -
drivers/infiniband/hw/mlx4/cq.c | 4 ---
drivers/infiniband/hw/mlx4/mad.c | 14 +++---------
drivers/infiniband/hw/mlx4/main.c | 8 ++-----
drivers/infiniband/hw/mlx4/mlx4_ib.h | 2 -
drivers/infiniband/hw/mlx4/qp.c | 21 ++++++-------------
drivers/infiniband/hw/mlx4/sysfs.c | 6 +----
drivers/infiniband/ulp/ipoib/ipoib_main.c | 6 ++---
include/rdma/ib_verbs.h | 30 +++++++++++++++++++++++++++
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 3 --
19 files changed, 87 insertions(+), 87 deletions(-)
next reply other threads:[~2015-03-25 15:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 15:09 Michael Wang [this message]
2015-03-25 15:12 ` [PATCH 1/2 RESEND] IB/Verbs: Use helpers to check transport and link layer Michael Wang
2015-03-25 15:14 ` [PATCH 2/2 RESEND] IB/Verbs: Use helpers to check IBoE technology Michael Wang
2015-03-26 14:09 ` [PATCH 0/2 RESEND] IB/Verbs: Use helpers to refine the checking on transport and link layer Doug Ledford
[not found] ` <1427378940.21101.100.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-26 16:04 ` Michael Wang
[not found] ` <55142DFD.2060100-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-03-26 16:27 ` Doug Ledford
2015-03-26 16:58 ` Michael Wang
[not found] ` <55143AAC.8040206-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-03-26 21:13 ` Jason Gunthorpe
[not found] ` <20150326211334.GA3359-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-03-27 9:52 ` Michael Wang
2015-03-27 15:55 ` Jason Gunthorpe
[not found] ` <20150327155530.GA21778-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-03-27 16:03 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5512CFB0.1050108@profitbricks.com \
--to=yun.wang@profitbricks.com \
--cc=Tatyana.E.Nikolova@intel.com \
--cc=alex.estrin@intel.com \
--cc=bfields@fieldses.org \
--cc=bvanassche@acm.org \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=edumazet@google.com \
--cc=erezsh@mellanox.com \
--cc=haggaie@mellanox.c \
--cc=hal.rosenstock@gmail.com \
--cc=ira.weiny@intel.com \
--cc=jackm@dev.mellanox.co.il \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=majd@mellanox.com \
--cc=matanb@mellanox.com \
--cc=mgorman@suse.de \
--cc=monis@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roland@kernel.org \
--cc=sagig@mellanox.com \
--cc=sean.hefty@intel.com \
--cc=swise@opengridcomputing.com \
--cc=trond.myklebust@primarydata.com \
--cc=yanb@mellanox.com \
--cc=ydroneaud@opteya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).