[PATCH] IB/srpt: Suppress a compiler warning

[PATCH] IB/srpt: Suppress a compiler warning

[Bart Van Assche]

Remove a BUG_ON(!ch) statement because it is superfluous - if
the ch pointer would be NULL then the assignment in the first
line of srpt_map_sg_to_ib_sge() would trigger a kernel oops anyway.

This patch suppresses the following compiler warning:

Possible null pointer dereference: ch - otherwise it is redundant to
check it against null.

Reported-by: David Binderman <dcb314-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
---
 drivers/infiniband/ulp/srpt/ib_srpt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c
b/drivers/infiniband/ulp/srpt/ib_srpt.c
index 6e0a477..4e74fc8 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -1095,7 +1095,6 @@ static int srpt_map_sg_to_ib_sge(struct
srpt_rdma_ch *ch,
 	int count, nrdma;
 	int i, j, k;

-	BUG_ON(!ch);
 	BUG_ON(!ioctx);
 	cmd = &ioctx->cmd;
 	dir = cmd->data_direction;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/srpt: Suppress a compiler warning

[Sagi Grimberg]

On 3/30/2015 1:37 PM, Bart Van Assche wrote:
> Remove a BUG_ON(!ch) statement because it is superfluous - if
> the ch pointer would be NULL then the assignment in the first
> line of srpt_map_sg_to_ib_sge() would trigger a kernel oops anyway.
>
> This patch suppresses the following compiler warning:
>
> Possible null pointer dereference: ch - otherwise it is redundant to
> check it against null.
>
> Reported-by: David Binderman <dcb314-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
> ---
>   drivers/infiniband/ulp/srpt/ib_srpt.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c
> b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index 6e0a477..4e74fc8 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -1095,7 +1095,6 @@ static int srpt_map_sg_to_ib_sge(struct
> srpt_rdma_ch *ch,
>   	int count, nrdma;
>   	int i, j, k;
>
> -	BUG_ON(!ch);
>   	BUG_ON(!ioctx);
>   	cmd = &ioctx->cmd;
>   	dir = cmd->data_direction;
>

Acked-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html