Re: [PATCH v2 02/11] IB/addr: Pass network namespace as a parameter

Haggai Eran
2015-04-21T10:29:42Z

On 20/04/2015 20:09, Jason Gunthorpe wrote:
> On Mon, Apr 20, 2015 at 12:03:33PM +0300, Haggai Eran wrote:
>> +/** rdma_addr_find_smac_by_sgid() - Find the src MAC and VLAN ID for a src GID
>> + * @sgid: Source GID to find the MAC and VLAN for.
>> + * @smac: A buffer to contain the resulting MAC address.
>> + * @vlan_id: Will contain the resulting VLAN ID.
>> + * @net: Network namespace to use for the address resolution.
>> + *
>> + * It is the caller's responsibility to keep the network namespace alive until
>> + * the function returns.
>> + */
>> +int rdma_addr_find_smac_by_sgid(union ib_gid *sgid, u8 *smac, u16 *vlan_id,
>> + struct net *net);
>
> kdocs are typically placed with the body of the function, not at the
> prototype.

I'll move it in the next revision. We did that because other functions
(rdma_translate_ip, rdma_resolve_ip) are documented inside ib_addr.h
this way.

Haggai