From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haggai Eran Subject: Re: [PATCH v2 02/11] IB/addr: Pass network namespace as a parameter Date: Tue, 21 Apr 2015 13:29:42 +0300 Message-ID: <55362696.7090400@mellanox.com> References: <1429520622-10303-1-git-send-email-haggaie@mellanox.com> <1429520622-10303-3-git-send-email-haggaie@mellanox.com> <20150420170925.GE7676@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150420170925.GE7676-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Doug Ledford , Roland Dreier , Sean Hefty , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liran Liss , Guy Shapiro , Shachar Raindel , Yotam Kenneth List-Id: linux-rdma@vger.kernel.org On 20/04/2015 20:09, Jason Gunthorpe wrote: > On Mon, Apr 20, 2015 at 12:03:33PM +0300, Haggai Eran wrote: >> +/** rdma_addr_find_smac_by_sgid() - Find the src MAC and VLAN ID for a src GID >> + * @sgid: Source GID to find the MAC and VLAN for. >> + * @smac: A buffer to contain the resulting MAC address. >> + * @vlan_id: Will contain the resulting VLAN ID. >> + * @net: Network namespace to use for the address resolution. >> + * >> + * It is the caller's responsibility to keep the network namespace alive until >> + * the function returns. >> + */ >> +int rdma_addr_find_smac_by_sgid(union ib_gid *sgid, u8 *smac, u16 *vlan_id, >> + struct net *net); > > kdocs are typically placed with the body of the function, not at the > prototype. I'll move it in the next revision. We did that because other functions (rdma_translate_ip, rdma_resolve_ip) are documented inside ib_addr.h this way. Haggai -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html