Re: [PATCH] IB/core: Fix unaligned accesses

[David Ahern <david.ahern-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]

On 4/29/15 3:30 PM, Jason Gunthorpe wrote:
> On Wed, Apr 29, 2015 at 03:24:19PM -0600, David Ahern wrote:
>> On 4/29/15 3:18 PM, Jason Gunthorpe wrote:
>>> On Wed, Apr 29, 2015 at 04:56:23PM -0400, David Ahern wrote:
>>>
>>>>   static void cm_mask_copy(u8 *dst, u8 *src, u8 *mask)
>>>>   {
>>>
>>> Do you know what call site is unaligned? A quick audit suggests that
>>> fixing a few possibly troublesome callers to be guaranteed 32 bit
>>> aligned should be fairly straight foward.
>>
>>
>> I believe this case is
>>
>> cm_find_listen() -> cm_compare_private_data() -> cm_mask_copy()
>
> Right, I'm pretty sure that is the main place that would have the 32
> bit alignment limitation since it is a on the wire message.
>
> I suggest changing the signature to:
>
> cm_mask_copy(u32 *dst, const u32 *src, const u32 *mask)
>
> And dealing with the fairly few resulting changes..

Confused. That does not deal with the alignment problem. Internal to 
cm_mask_copy unsigned longs are used (8-bytes), so why change the 
signature to u32?


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html