Re: [PATCH 07/12] IB/srp: Remove superfluous casts

[Sagi Grimberg <sagig@dev.mellanox.co.il>]

On 4/30/2015 12:00 PM, Bart Van Assche wrote:
> A long time ago the data type int64_t was declared as long long
> on x86 systems and as long on PPC systems. Today that data type
> is declared as long long on all Linux architectures. This means
> that the casts from uint64_t into unsigned long long are
> superfluous.  Remove these superfluous casts.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Sagi Grimberg <sagig@mellanox.com>
> Cc: Sebastian Parschauer <sebastian.riemer@profitbricks.com>
> ---
>   drivers/infiniband/ulp/srp/ib_srp.c | 13 +++++--------
>   1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
> index 5d7d790..8b6f166 100644
> --- a/drivers/infiniband/ulp/srp/ib_srp.c
> +++ b/drivers/infiniband/ulp/srp/ib_srp.c
> @@ -780,7 +780,7 @@ static int srp_send_req(struct srp_rdma_ch *ch, bool multich)
>   		shost_printk(KERN_DEBUG, target->scsi_host,
>   			     PFX "Topspin/Cisco initiator port ID workaround "
>   			     "activated for target GUID %016llx\n",
> -			     (unsigned long long) be64_to_cpu(target->ioc_guid));
> +			     be64_to_cpu(target->ioc_guid));
>   		memset(req->priv.initiator_port_id, 0, 8);
>   		memcpy(req->priv.initiator_port_id + 8,
>   		       &target->srp_host->srp_dev->dev->node_guid, 8);
> @@ -2561,8 +2561,7 @@ static ssize_t show_id_ext(struct device *dev, struct device_attribute *attr,
>   {
>   	struct srp_target_port *target = host_to_target(class_to_shost(dev));
>
> -	return sprintf(buf, "0x%016llx\n",
> -		       (unsigned long long) be64_to_cpu(target->id_ext));
> +	return sprintf(buf, "0x%016llx\n", be64_to_cpu(target->id_ext));
>   }
>
>   static ssize_t show_ioc_guid(struct device *dev, struct device_attribute *attr,
> @@ -2570,8 +2569,7 @@ static ssize_t show_ioc_guid(struct device *dev, struct device_attribute *attr,
>   {
>   	struct srp_target_port *target = host_to_target(class_to_shost(dev));
>
> -	return sprintf(buf, "0x%016llx\n",
> -		       (unsigned long long) be64_to_cpu(target->ioc_guid));
> +	return sprintf(buf, "0x%016llx\n", be64_to_cpu(target->ioc_guid));
>   }
>
>   static ssize_t show_service_id(struct device *dev,
> @@ -2579,8 +2577,7 @@ static ssize_t show_service_id(struct device *dev,
>   {
>   	struct srp_target_port *target = host_to_target(class_to_shost(dev));
>
> -	return sprintf(buf, "0x%016llx\n",
> -		       (unsigned long long) be64_to_cpu(target->service_id));
> +	return sprintf(buf, "0x%016llx\n", be64_to_cpu(target->service_id));
>   }
>
>   static ssize_t show_pkey(struct device *dev, struct device_attribute *attr,
> @@ -2771,7 +2768,7 @@ static int srp_add_target(struct srp_host *host, struct srp_target_port *target)
>
>   	target->state = SRP_TARGET_SCANNING;
>   	sprintf(target->target_name, "SRP.T10:%016llX",
> -		 (unsigned long long) be64_to_cpu(target->id_ext));
> +		be64_to_cpu(target->id_ext));
>
>   	if (scsi_add_host(target->scsi_host, host->srp_dev->dev->dma_device))
>   		return -ENODEV;
>

Looks good.

Reviewed-by: Sagi Grimberg <sagig@mellanox.com>