From: Michael Wang <yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
To: "ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC PATCH 3/5] IB/core: Convert cap_ib_mad to core_cap_flags bit mask
Date: Tue, 05 May 2015 10:00:13 +0200 [thread overview]
Message-ID: <5548788D.8050708@profitbricks.com> (raw)
In-Reply-To: <20150504224342.GD10115-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
On 05/05/2015 12:43 AM, ira.weiny wrote:
[snip]
>
>>
>>> static inline int cap_ib_mad(struct ib_device *device, u8 port_num)
>>> {
>>> - return rdma_ib_or_iboe(device, port_num);
>>> + return !!(device->core_cap_flags[port_num] & RDMA_CORE_CAP_IB_MAD);
>>
>>
>> 'bool' is OK in the kernel, just use that instead of !! - in fact all of
>> thse cap returns should return bool. Michael should fix that in his
>> series too.
>
> Michael?
Ok, I will use bool in next version :-)
Regards,
Michael Wang
>
> Ira
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-05 8:00 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 6:14 [RFC PATCH 0/5] Add Core Capability Bits to use in Management helpers ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1430720099-32512-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-05-04 6:14 ` [RFC PATCH 1/5] IB/core: Add Core Capability flags to ib_device ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1430720099-32512-2-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-05-04 14:41 ` Doug Ledford
[not found] ` <1430750492.2407.9.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-04 16:40 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FCA17C-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-05-04 17:38 ` Doug Ledford
[not found] ` <1430761111.2407.85.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-04 18:26 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FCA2F1-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-05-04 19:40 ` Doug Ledford
[not found] ` <1430768425.2407.143.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-04 21:07 ` Jason Gunthorpe
[not found] ` <20150504210741.GA20839-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-05 19:59 ` Liran Liss
2015-05-04 20:21 ` Dave Goodell (dgoodell)
2015-05-05 19:51 ` Liran Liss
[not found] ` <HE1PR05MB1418DF0669B6E6CABE1D9F1EB1D10-eBadYZ65MZ87O8BmmlM1zNqRiQSDpxhJvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2015-05-05 20:22 ` Dave Goodell (dgoodell)
[not found] ` <20BA79B2-9DA5-49B3-8455-BD4021CB882C-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2015-05-05 20:29 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FCAEFD-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-05-06 14:25 ` Liran Liss
2015-05-09 3:32 ` Doug Ledford
[not found] ` <1431142328.2407.488.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-11 22:19 ` Dave Goodell (dgoodell)
[not found] ` <CCC397F5-31B6-4A35-94E0-7EAAE6C4803F-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2015-05-11 22:39 ` Jason Gunthorpe
[not found] ` <20150511223930.GA15628-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-12 17:41 ` Dave Goodell (dgoodell)
[not found] ` <DC760F33-F704-4763-AEA3-6DE9016D0687-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2015-05-12 18:08 ` Jason Gunthorpe
2015-05-11 6:42 ` ira.weiny
[not found] ` <20150511064232.GA3042-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-05-11 22:26 ` Dave Goodell (dgoodell)
[not found] ` <D72B89F6-B333-4DC2-9BA7-CB45EBC31843-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2015-05-12 2:13 ` Weiny, Ira
[not found] ` <2807E5FD2F6FDA4886F6618EAC48510E1107C20E-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-05-12 17:56 ` Dave Goodell (dgoodell)
2015-05-05 19:27 ` Liran Liss
[not found] ` <HE1PR05MB1418E58A6EB92D92B78C76A0B1D10-eBadYZ65MZ87O8BmmlM1zNqRiQSDpxhJvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2015-05-08 18:56 ` Doug Ledford
[not found] ` <1431111412.2407.463.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-08 20:06 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FCD719-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-05-08 20:30 ` Doug Ledford
[not found] ` <1431117051.2407.468.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-08 20:56 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FCD78C-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-05-08 21:48 ` Jason Gunthorpe
[not found] ` <20150508214855.GA3917-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-13 20:41 ` Liran Liss
2015-05-04 16:42 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FCA192-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-05-04 16:48 ` Doug Ledford
[not found] ` <1430758097.2407.59.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-04 16:53 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FCA1D9-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-05-04 16:56 ` Doug Ledford
[not found] ` <1430758566.2407.62.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-04 17:25 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373A8FCA217-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-05-04 17:31 ` Weiny, Ira
[not found] ` <2807E5FD2F6FDA4886F6618EAC48510E11069818-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-05-04 17:34 ` Hefty, Sean
2015-05-04 18:36 ` Jason Gunthorpe
[not found] ` <20150504183657.GA20586-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-04 22:32 ` ira.weiny
[not found] ` <20150504223234.GB10115-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-05-04 23:16 ` ira.weiny
[not found] ` <20150504231622.GE10115-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-05-04 23:52 ` Jason Gunthorpe
2015-05-04 6:14 ` [RFC PATCH 2/5] IB/core: Replace query_protocol callback with Core Capability flags check ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-05-04 6:14 ` [RFC PATCH 3/5] IB/core: Convert cap_ib_mad to core_cap_flags bit mask ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1430720099-32512-4-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-05-04 16:49 ` Hefty, Sean
2015-05-04 18:46 ` Jason Gunthorpe
[not found] ` <20150504184610.GB20586-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-05-04 22:43 ` ira.weiny
[not found] ` <20150504224342.GD10115-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-05-05 8:00 ` Michael Wang [this message]
2015-05-05 8:26 ` Michael Wang
2015-05-04 6:14 ` [RFC PATCH 4/5] IB/core: Add rdma_dev_max_mad_size call ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-05-04 6:14 ` [RFC PATCH 5/5] IB/core: Add cap_opa_mad helper using RDMA_CORE_CAP_OPA_MAD flag ira.weiny-ral2JQCrhuEAvxtiuMwx3w
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5548788D.8050708@profitbricks.com \
--to=yun.wang-eikl63zcoxah+58jc4qpia@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox