Re: [PATCH RFC] IB/core, cma: Nice log-friendly string helpers

Or Gerlitz
2015-05-10T12:04:21Z

On 5/10/2015 1:04 PM, Sagi Grimberg wrote:
> Some of us keep revisiting the code to decode IB/RDMA_CM enumerations
> that appear in our logs. Let's borrow the nice logging helpers xprtrdma
> has for CMA events, IB events and WC statuses. Also, have srp, iser and
> isert be early adopters.
>
> Signed-off-by: Sagi Grimberg<sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> I have been using this patch for some time now so I thought
> it would be nice to get it out.
>
> drivers/infiniband/ulp/iser/iser_verbs.c | 25 +++++---
> drivers/infiniband/ulp/srp/ib_srp.c | 15 +++--
> include/rdma/ib_verbs.h | 55 ++++++++++++++++++
> include/rdma/rdma_cm.h | 23 ++++++++
> net/sunrpc/xprtrdma/verbs.c | 90 ++----------------------------
> 5 files changed, 106 insertions(+), 102 deletions(-)

Nice initiative (was on my Q for years...), please make sure to plug
into the RDS code into this party, that isre-use their
RDS_IB_EVENT_STRING, RDS_CM_EVENT_STRING and such to avoid us declaring
the same strings over and over.

Or.