Re: [PATCH v4 2/2] ulps: Align several ULPs to use core/rdma_cm logging helpers

[Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>]

On 5/12/2015 2:04 PM, Yann Droneaud wrote:
> Hi,
>
> Le mardi 12 mai 2015 à 13:12 +0300, Sagi Grimberg a écrit :
>> Remove rds & xprtrdma specific helpers and have them and
>> srp, iser, isert use the generic helpers. While we're at it
>> align svcrdma as well.
>>
>> Reviewed-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
>> Reviewed-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>> Signed-off-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> Signed-off-by: Anna Schumaker <anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
>
> That's quite a big patch. Why not splitting it per ulp ?

Its just cosmetics, I can do it though...

>
> Anyway, is changing the format of the messages going to break some
> userspace trying to parse those ?
>

I don't think logging is something that user-space should rely on
to be unmodified forever.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html