RE: [PATCH v3 for-next 05/13] IB/cm: Reference count ib_cm_ids

Hefty, Sean
2015-05-20T00:49:44Z

> > I wonder if the existing ib_cm interface is even what we want.
> > Currently, the rdma_cm pushes the private data (i.e. IP address)
> > comparison into the ib_cm. This is only used by the rdma_cm.
> > Should that instead be moved out of the ib_cm and handled in the
> > rdma_cm? And then update the ib_cm to support multiple listens on
> > the same service id.
>
> Well, that really is the problem here, the private data compare
> doesn't really do enough because rdma cm wildcard's the IP address and
> does it's own check anyhow. So I see all of this as different
> proposals on how to fix that. rdma_cm basically already does most of
> the private data compare itself.

Maybe the first thing to fix is this. Since the private data compare is no longer sufficient, remove it and update the rdma_cm to handle the change. Regardless of how the code ends up structured, the namespace support should then easily fit into that solution.

- Sean