RE: [PATCH v3 for-next 00/13] Add network namespace support in the RDMA-CM

Hefty, Sean
2015-05-13T17:30:01Z

> > > > How does network namespace support work with iWarp?
> > >
> > > We did not implement network namespace support for iWarp. Only for
> > > InfiniBand. The iWarp code continues to use &init_net whenever a
> network
> > > namespace is needed, as it does today.
> >
> > We need a solution that supports both. It's odd for the RDMA CM to
> > support a feature only for some devices, when the solution should be
> > general.
>
> Yes, it is not optimal, but given that every protocol uses a
> completely different scheme to interact with netdev, I'm not sure
> there is another option but to do them piecemeal?

Piecemeal isn't necessarily the problem. No thought appears to have been given to how this scheme supports iWarp at all. My concern is around whether any changes should be made to the ib_cm, versus keeping everything contained in the rdma_cm. I.e. do we want the same kref schemed added to the iw_cm, or keep reference counts only in the rdma_cm?

> I'm happy to see this patch much smaller and without the vestigial
> half-roce support that the prior version included.

agreed