Re: [PATCH for-next V5 00/12] Move RoCE GID management to IB/Core

[Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

On 6/10/2015 6:09 PM, Hefty, Sean wrote:
>> Sean, this change is needed b/c two drivers have (mlx4 and ocrda) and
>> more two to come soon (mlx5 and soft-Roce) would have the very same
>> logic of constructing the port GID table according to netdev events and
>> such, no point in repeating this logic/code over and over.
>>
>> Matan explained why we don't have 2 x Y deletions and 1 x Y insertions.
>
> It more than doubles the amount of code.  That's not a cleanup.  It introduces a bunch of new functionality.  Jason has asked repeatedly to remove the RoCEv2 code, and that has been ignored repeatedly.  As far as I'm concerned, this patch is not worth my time, and I will no longer even bother following this series.

Well, saying that without giving one evidence of RoCE V2 code in this 
series is simply non-sense. Regarding Jason's comments, all of them were 
either fixed or answered.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html