From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matan Barak Subject: Re: [PATCH for-next V5 00/12] Move RoCE GID management to IB/Core Date: Wed, 10 Jun 2015 18:19:35 +0300 Message-ID: <55785587.6010208@mellanox.com> References: <1433772735-22416-1-git-send-email-matanb@mellanox.com> <1828884A29C6694DAF28B7E6B8A82373A8FE5D17@ORSMSX109.amr.corp.intel.com> <55769561.8000300@mellanox.com> <5577FAFB.8020205@mellanox.com> <1828884A29C6694DAF28B7E6B8A82373A8FE6616@ORSMSX109.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373A8FE6616-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Hefty, Sean" , Or Gerlitz , Doug Ledford , Jason Gunthorpe Cc: Moni Shoua , Somnath Kotur , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 6/10/2015 6:09 PM, Hefty, Sean wrote: >> Sean, this change is needed b/c two drivers have (mlx4 and ocrda) and >> more two to come soon (mlx5 and soft-Roce) would have the very same >> logic of constructing the port GID table according to netdev events and >> such, no point in repeating this logic/code over and over. >> >> Matan explained why we don't have 2 x Y deletions and 1 x Y insertions. > > It more than doubles the amount of code. That's not a cleanup. It introduces a bunch of new functionality. Jason has asked repeatedly to remove the RoCEv2 code, and that has been ignored repeatedly. As far as I'm concerned, this patch is not worth my time, and I will no longer even bother following this series. Well, saying that without giving one evidence of RoCE V2 code in this series is simply non-sense. Regarding Jason's comments, all of them were either fixed or answered. > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html