From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Vaishali Thakkar <vthakkar1994@gmail.com>,
Doug Ledford <dledford@redhat.com>
Cc: Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/srpt: Convert use of __constant_cpu_to_beXX to cpu_to_beXX
Date: Tue, 23 Jun 2015 07:35:33 -0700 [thread overview]
Message-ID: <55896EB5.4030307@sandisk.com> (raw)
In-Reply-To: <20150623044153.GA21400@vaishali-Ideapad-Z570>
On 06/22/15 21:41, Vaishali Thakkar wrote:
> if (!slot || slot > 16) {
> mad->mad_hdr.status
> - = __constant_cpu_to_be16(DM_MAD_STATUS_INVALID_FIELD);
> + = cpu_to_be16(DM_MAD_STATUS_INVALID_FIELD);
> return;
> }
Without this change several statements exceeded 80 characters and were
split because of that reason. Please change the multi-line statements
that have been reduced to less than 80 columns into single-line statements.
Bart.
prev parent reply other threads:[~2015-06-23 14:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 4:41 [PATCH] IB/srpt: Convert use of __constant_cpu_to_beXX to cpu_to_beXX Vaishali Thakkar
2015-06-23 14:35 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55896EB5.4030307@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox