From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: COMMERCIAL: [PATCH] IB/mad: Remove improper use of BUG_ON Date: Thu, 25 Jun 2015 12:27:59 +0300 Message-ID: <558BC99F.10400@mellanox.com> References: <1435197004-32495-1-git-send-email-ira.weiny@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435197004-32495-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 6/25/2015 4:50 AM, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > From: Ira Weiny > > commit 97f229a8515f932e5adc6cdfa18cc1440235b9fd > IB/mad: Add support for additional MAD info to/from drivers > > added BUG_ON's which were inappropriate for a condition which should never > happen. Change these to be WARN_ON_ONCE as a debugging aid. > > Signed-off-by: Ira Weiny Ira, you've put the wrong commit id, this isn't the one that appears in Linus tree, also the change-log should be written in a certain way when you fix an earlier commit, see: We recently added BUG_ON's which were inappropriate for a condition which should never happen. Change these to be WARN_ON_ONCE as a debugging aid. Fixes: 4cd7c9479aff ('IB/mad: Add support for additional MAD info to/from drivers') Signed-off-by: Ira Weiny -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html