Re: [PATCH RFC] RDMA/core: add rdma_get_dma_mr()

Haggai Eran
2015-06-28T16:01:08Z

On 26/06/2015 00:29, Steve Wise wrote:
> The semantics for MR access rights are not consistent across RDMA
> protocols. So rather than have applications try and glean what they need,
> have them pass in the intended roles for the MR to be allocated and let
> the RDMA core select the appropriate access rights given the roles and
> device capabilities.

I wanted to point out that with this scheme the ULP may sometimes get an
MR with a wider set of permissions that it asked for, and I'm not sure
that's always safe. Perhaps the ULP wants to guarantee that the MR
doesn't allow certain kinds of accesses and doesn't expect the verbs
layer to change that.

This patch looks fine since it is just a helper function, but if you
replace the MR creation with these flags, you might confuse users to
think that they can control e.g. write sink and read sink separately.

Haggai