Re: [PATCH RFC] RDMA/core: add rdma_get_dma_mr()

Haggai Eran
2015-06-28T15:47:15Z

On 26/06/2015 00:29, Steve Wise wrote:
> +enum rdma_mr_roles {
> + RDMA_MRR_RECV = 1,
> + RDMA_MRR_SEND = (1<<1),
> + RDMA_MRR_READ_SOURCE = (1<<2),
> + RDMA_MRR_READ_SINK = (1<<3),

Maybe it's just me, but it took me a second to figure out which was the
source and which was the sink in RDMA reads. Do you think calling them
initiator and responder/target would be better?

> + RDMA_MRR_WRITE_SOURCE = (1<<4),
> + RDMA_MRR_WRITE_SINK = (1<<5),
> + RDMA_MRR_ATOMIC = (1<<6),
> + RDMA_MRR_MW_BIND = (1<<7),
> + RDMA_MRR_ZERO_BASED = (1<<8),
> + RDMA_MRR_ACCESS_ON_DEMAND = (1<<9),
> +};