From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH V2] IB/mad: Remove improper use of BUG_ON Date: Wed, 1 Jul 2015 10:43:23 +0300 Message-ID: <55939A1B.5030307@mellanox.com> References: <1435240370-18161-1-git-send-email-ira.weiny@intel.com> <558C18DF.6010307@mellanox.com> <2807E5FD2F6FDA4886F6618EAC48510E110A343B@CRSMSX101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2807E5FD2F6FDA4886F6618EAC48510E110A343B-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Weiny, Ira" , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 6/25/2015 6:23 PM, Weiny, Ira wrote: >> On 6/25/2015 4:52 PM, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: >>> From: Ira Weiny >>> >>> We recently added BUG_ON's which were inappropriate for a condition >>> which should never happen. Change these to be WARN_ON_ONCE as a >> debugging aid. >>> Fixes: 4cd7c9479aff ('IB/mad: Add support for additional MAD info >>> to/from drivers') >>> >>> Signed-off-by: Ira Weiny >> remove the blank line, > Is there some documentation on this stuff? I don't know > > This does not mention anything about white space. > > https://www.kernel.org/doc/Documentation/SubmittingPatches > > I don't mind following the proper conventions if I knew what they were. so look around a bit... e.g on networking patches and see that no blank lines.. it's add sort of small eye damaging for someone looking on kernel logs. Or. > > Ira > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html