From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: Bart Van Assche
<bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: COMMERCIAL: Re: [PATCH V3] IB/mad: Fix 0-day build
Date: Wed, 1 Jul 2015 10:46:38 +0300 [thread overview]
Message-ID: <55939ADE.3070307@mellanox.com> (raw)
In-Reply-To: <558C3A55.3050701-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
On 6/25/2015 8:28 PM, Bart Van Assche wrote:
> On 06/25/2015 09:04 AM, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
>> From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>
>> The define OPA_LID_PERMISSIVE is big endian and was compared to cpu
>> value
>> opa_drslid.
>>
>> 0-day build caught this while building with the OPA (hfi1) driver
>> which was
>> recently sent to the list.
>>
>> Fixes: 8e4349d13f33 (IB/mad: Add final OPA MAD processing)
>
> Hello Ira,
>
> For future patches please make sure that the subject of the patch
> describes what has been fixed instead of referring to the tool that
> detected the issue.
>
Also, Ira, make sure to avoid two patches with the same name in the same
series, such as
f28990b IB/mad: Add partial Intel OPA MAD support
548ead1 IB/mad: Add partial Intel OPA MAD support
Maybe you should ask Sean to go over patch titles and change-logs till
you'll be up to speed on how this should be done, he has lots of kernel
experience
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-01 7:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 16:04 [PATCH V3] IB/mad: Fix 0-day build ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1435248289-16477-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-25 17:28 ` Bart Van Assche
[not found] ` <558C3A55.3050701-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-07-01 7:46 ` Or Gerlitz [this message]
2015-07-08 23:01 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55939ADE.3070307@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox